Skip to content

DrawTextBlob benchmark crashes on Impeller backends #192671

New issue
New issue
Closed
#192677
Closed
DrawTextBlob benchmark crashes on Impeller backends#192671
#192677
Labels
P2Important issues not at the top of the work liste: impellerImpeller rendering backend issues and features requestsengineflutter/engine related. See also e: labels.team-engineOwned by Engine teamtriaged-engineTriaged by Engine team

Description

@artemkulyk
artemkulyk
opened on Sep 12, 2026

The primitive_rendering_benchmarks DrawTextBlob case always builds a DlTextSkia. On Impeller backends DlTextSkia::GetTextFrame() is null, and DlDispatcherBase::drawText FML_CHECKs that the frame is non-null, so the process aborts.

This is a local macOS/iOS benchmark bug. Impeller Metal variants of this suite are compiled only when ENABLE_METAL_BENCHMARKS is set (mac/iOS). Linux CI runs primitive_rendering_benchmarks without those backends, so this does not fail LUCI.

Production Impeller text already uses Impeller text frames. The benchmark should build DlTextImpeller when the surface provider targets Impeller.

Activity

  1. mbcorona
    added
    engineflutter/engine related. See also e: labels.
    e: impellerImpeller rendering backend issues and features requests
    team-engineOwned by Engine team
    on Sep 12, 2026
  2. gaaclarke
    added
    P2Important issues not at the top of the work list
    triaged-engineTriaged by Engine team
    on Sep 14, 2026
  3. auto-submit
    closed this as completedin #192677on Sep 21, 2026
  4. pull
    added a commit that references this issue on Sep 21, 2026

    [Impeller] Fix the text benchmark on Impeller backends (flutter#192677)

    c251c17

  5. github-actions commented on Oct 5, 2026

    @github-actions
    github-actionsBot
    on Oct 5, 2026 – with GitHub Actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  6. github-actions
    locked as resolved and limited conversation to collaborators on Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work liste: impellerImpeller rendering backend issues and features requestsengineflutter/engine related. See also e: labels.team-engineOwned by Engine teamtriaged-engineTriaged by Engine team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions