Repository navigation
Switching branches can skip Dashboard Checks #191970
Description
Help us understand the severity of this issue
- breakage; unable to contribute or trigger builds will no workarounds
- inconvenient workarounds exist, but significant effort required
- needed for a Flutter team-wide priority (already agreed upon)
- nice-to-have; none of the above
What do you need help with
Observed in #191931
The PR was opened targeting the main branch. The workflow blocking changes on main failed as expected (maybe it should leave a comment? I'll push a PR). Dashboard Checks did not schedule anything, it skipped running and reported green - I assume because it recognized this was not targeting the right branch. Cool optimization, very efficient! :)
When the author switched the target branch to master, CI did not appear to recognize this. Dashboard checks remained green, having never run anything. I rebased to give it a kick and run tests, so workaround-able. But, could cause issues if..
- someone opens a PR targeting
main, - the dashboard goes green,
- the target branch is switched
- dashboard stays green
- no one notices
- PR lands
- tree goes red.
Activity
jtmcdole commentedon Aug 28, 2026
@ievdokdm - can you take a look at why Dashboard Checks wasn't scheduled for #191931 after it was correctly updated to the new base branch?
Update no-main-prs to leave a comment (flutter#191973)
ievdokdm commentedon Aug 28, 2026
There are dashboard checks for latest sha for this pr: https://flutter-dashboard.appspot.com/#/presubmit?repo=flutter&pr=191931&sha=1dbc88a669d5424b5ea1194c64ec152fa0ff9a2c
@Piinks what sha have no dashboard checks ?
Piinks commentedon Aug 28, 2026
2f0dea9
1dbc88a was from when I rebased after the branch was switched and CI did not update
ievdokdm commentedon Aug 28, 2026
Switching branch skipped whole github check run?!
There are checks only for 1dbc88a version.
As a result there is no
dashboard checksPiinks commentedon Aug 28, 2026
Not sure if rebasing made this unclear to debug. We can probably reproduce it in a fresh PR.
The PR was opened against
main, the dashboard was green, when I clicked through it said it had skipped running the checks. I assume because it was already failing the workflow for targeting main instead of master.I told the contributor to change the target. They did. The Dashboard checks did not update, they remained green in the skipped state. I rebased to trigger tests to run.
Piinks commentedon Aug 28, 2026
I was looking closely at this PR since it was adding over 3000 new tests and I wanted to make sure the runtime was reasonable. :)
ievdokdm commentedon Aug 28, 2026
https://pantheon.corp.google.com/logs/query;query=resource.type%3D%22gae_app%22%0Aresource.labels.module_id%3D%22default%22%0A-httpRequest.userAgent%3D%22GitHub-Hookshot%2F1606fa5%22%0A-httpRequest.userAgent%3D%22GoogleHC%2F1.0%22%0A-httpRequest.userAgent%3D%22CloudPubSub-Google%22%0ASEARCH%2528%222f0dea960f657896402d1eb8b791a0ff8f17c703%22%2529%0Aseverity%3D%22WARNING%22;cursorTimestamp=2026-08-28T15:50:53.142Z;duration=P1D?referrer=search&invt=AbvHVg&project=flutter-dashboard&e=-13802955&mods=logs_tg_prod
for some reason build bucket returns 0 builds for this sha