Repository navigation
[go_router_builder] Flutter/packages Windows custom packages test failing #191892
Description
Full logs can be found here, but all the test failures have the same line:
Which: is different.
Expected: ... a.$route(\r\n path: ...
Actual: ... a.$route(\n path: ' ...
May be a windows bug?
I'm not able to reproduce locally and it looks like the latest roll fails, but the test passed on the roll that started the post submit error:
flutter/packages#12619
Full test failure output:
+3 -6: verify test_inputs\extra_value.dart [E]
Expected: 'RouteBase get $extraValueRoute => GoRouteData.$route(\r\n'
' path: \'/default-value-route\',\r\n'
' hasOverriddenOnExit: false,\r\n'
' factory: $ExtraValueRoute._fromState,\r\n'
');\r\n'
'\r\n'
'mixin $ExtraValueRoute on GoRouteData {\r\n'
' static ExtraValueRoute _fromState(GoRouterState state) => ExtraValueRoute(\r\n'
' param:\r\n'
' _$convertMapValue(\'param\', state.uri.queryParameters, int.parse) ?? 0,\r\n'
' $extra: state.extra as int?,\r\n'
' );\r\n'
'\r\n'
' ExtraValueRoute get _self => this as ExtraValueRoute;\r\n'
'\r\n'
' @override\r\n'
' String get location => GoRouteData.$location(\r\n'
' \'/default-value-route\',\r\n'
' queryParams: {if (_self.param != 0) \'param\': _self.param.toString()},\r\n'
' );\r\n'
'\r\n'
' @override\r\n'
' void go(BuildContext context) => context.go(location, extra: _self.$extra);\r\n'
'\r\n'
' @override\r\n'
' Future<T?> push<T>(BuildContext context) =>\r\n'
' context.push<T>(location, extra: _self.$extra);\r\n'
'\r\n'
' @override\r\n'
' void pushReplacement(BuildContext context) =>\r\n'
' context.pushReplacement(location, extra: _self.$extra);\r\n'
'\r\n'
' @override\r\n'
' void replace(BuildContext context) =>\r\n'
' context.replace(location, extra: _self.$extra);\r\n'
'}\r\n'
'\r\n'
'T? _$convertMapValue<T>(\r\n'
' String key,\r\n'
' Map<String, String> map,\r\n'
' T? Function(String) converter,\r\n'
') {\r\n'
' final value = map[key];\r\n'
' return value == null ? null : converter(value);\r\n'
'}\r\n'
''
Actual: 'RouteBase get $extraValueRoute => GoRouteData.$route(\n'
' path: \'/default-value-route\',\n'
' hasOverriddenOnExit: false,\n'
' factory: $ExtraValueRoute._fromState,\n'
');\n'
'\n'
'mixin $ExtraValueRoute on GoRouteData {\n'
' static ExtraValueRoute _fromState(GoRouterState state) => ExtraValueRoute(\n'
' param:\n'
' _$convertMapValue(\'param\', state.uri.queryParameters, int.parse) ?? 0,\n'
' $extra: state.extra as int?,\n'
' );\n'
'\n'
' ExtraValueRoute get _self => this as ExtraValueRoute;\n'
'\n'
' @override\n'
' String get location => GoRouteData.$location(\n'
' \'/default-value-route\',\n'
' queryParams: {if (_self.param != 0) \'param\': _self.param.toString()},\n'
' );\n'
'\n'
' @override\n'
' void go(BuildContext context) => context.go(location, extra: _self.$extra);\n'
'\n'
' @override\n'
' Future<T?> push<T>(BuildContext context) =>\n'
' context.push<T>(location, extra: _self.$extra);\n'
'\n'
' @override\n'
' void pushReplacement(BuildContext context) =>\n'
' context.pushReplacement(location, extra: _self.$extra);\n'
'\n'
' @override\n'
' void replace(BuildContext context) =>\n'
' context.replace(location, extra: _self.$extra);\n'
'}\n'
'\n'
'T? _$convertMapValue<T>(\n'
' String key,\n'
' Map<String, String> map,\n'
' T? Function(String) converter,\n'
') {\n'
' final value = map[key];\n'
' return value == null ? null : converter(value);\n'
'}\n'
''
Which: is different.
Expected: ... a.$route(\r\n path: ...
Actual: ... a.$route(\n path: ' ...
^
Differ at offset 54
Activity
bparrishMines commentedon Aug 27, 2026
@chunhtai since you were the last known owner.
cc @stuartmorgan-g since we don't seem to have a current owner.
[-][go_router_builder] Flutter/packages custom packages test failing[/-][+][go_router_builder] Flutter/packages Windows custom packages test failing[/+]bparrishMines commentedon Aug 27, 2026
Ok trying to update platform compatibility in flutter/packages#12650
stuartmorgan-g commentedon Aug 27, 2026
I'm not sure what the cause of the change was (maybe something bot-level?) but making the check agnostic to line separators definitely seems reasonable to me.
chunhtai commentedon Aug 27, 2026
I can put up a pr to make new line neutral check
[go_router_builder] Fixes text golden test to ignore platform specifi…
[go_router_builder] Fixes text golden test to ignore platform specifi…
[go_router_builder] Fixes text golden test to ignore platform specifi…
github-actions commentedon Sep 10, 2026
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.