Skip to content

[Web Golden Testing] Support local golden testing and DPR alignment in flutter_tools and framework #191371

Closed

Description

@harryterkelsen

Part of #191313

Context

In #191314 (resolved by #191318), we implemented local screenshot and golden baseline diffing for Web Engine unit tests (felt test) using Skia Gold's REST API and in-memory pixel diffing.

Framework web tests run via flutter test --platform=chrome, which executes through packages/flutter_tools. We need to bring parity to flutter_tools and framework web golden testing as a separate follow-up step.

Problems & Requirements

  1. Device Pixel Ratio (DPR) Alignment ([web] Flutter test suite in the web needs love. #143124):
    • In packages/flutter_tools/lib/src/web/chrome.dart, headless Chrome starts without explicit device scale factor flags, defaulting to DPR = 1.0, while packages/flutter_test/lib/src/_test_selector_web.dart overrides DPR to 3.0 in web test environments.
    • Update packages/flutter_tools to pass --force-device-scale-factor and ensure browser device emulation matches framework expectations.
  2. Skia Gold REST Baselines for Framework Goldens:
    • Update package:flutter_goldens / flutter_goldens_web to retrieve baselines from Skia Gold's REST API and perform local comparison.
  3. Re-enable & Validate Skipped Tests ([web] skipped image tests failing gold checks when enabled. #87933):
    • Unskip and validate packages/flutter/test/widgets/image_test.dart golden tests under the new workflow.

Related Issues

Activity

  1. added
    in triagePresently being triaged by the triage team
    toolAffects the "flutter" command-line tool. See also t: labels.
    platform-webWeb applications specifically
    team-webOwned by Web platform team
    and removed
    in triagePresently being triaged by the triage team
    on Aug 20, 2026
  2. added
    P1High-priority issues at the top of the work list
    on Aug 26, 2026
  3. github-actions commented on Sep 23, 2026

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  4. locked as resolved and limited conversation to collaborators on Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

P1High-priority issues at the top of the work listplatform-webWeb applications specificallyteam-webOwned by Web platform teamtoolAffects the "flutter" command-line tool. See also t: labels.triaged-webTriaged by Web platform team

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions