Skip to content

Ergonomics of re-runs + autosubmit are worse under unified checks #191005

Open

Description

@stuartmorgan-g

Help us understand the severity of this issue

  • breakage; unable to contribute or trigger builds will no workarounds
  • inconvenient workarounds exist, but significant effort required
  • needed for a Flutter team-wide priority (already agreed upon)
  • nice-to-have; none of the above

What do you need help with

The interaction between autosubmit and the new unified check runs is (at least in flutter/packages, but I assume this happens in flutter/flutter as well) much less convenient when re-running flaky tests than the pre-unification flow.

(For context here: flutter/packages runs a lot of tests, across a lot of different types of tests, and there's frequently a non-trivial amount of flake. Obviously that's not ideal, obviously we should not have flake and we do try to keep it under control, but it's a constant battle that we never win so a regression in how it impacts engineers is a problem.)

The old workflow when something that we wanted to autosubmit had presubmit flake was:

  • trigger a re-run of the flaky tests
  • add autosubmit
  • go do other things

Because a re-run immediately changed the status back to pending, autosubmit would wait patiently in the background, and then (assuming it didn't flake again) immediately land the PR once the test completed, with no further interation.

The new workflow is:

  • trigger a re-run
  • go do other things
  • at some point remember that you were trying to land something, and go check on it
  • if it's green, add autosubmit

This requires two manual interventions, separated by a bunch of time, and with no notification system. I've had this add a day to landing because I got busy after the second step and forgot to check back until the next day.

This is necessary because the status of the unified check seems to stay failed until after the re-runs complete, rather than becoming pending again.

Activity

  1. jtmcdole commented on Aug 17, 2026

    @jtmcdole
    Member

    @ievdokdm recently made a change to update the test status for Dashboard Checks when all failed tests are rerun. Can you check again, @stuartmorgan-g ?

  2. added
    P2Important issues not at the top of the work list
    on Aug 17, 2026
  3. removed their assignment
    on Aug 17, 2026
  4. stuartmorgan-g commented on Aug 17, 2026

    @stuartmorgan-g
    ContributorAuthor

    I just re-tested on flutter/packages#12307 which had a failed test. I pressed this button:

    Image

    then waited until it showed as running (yellow spinner), and the PR still shows the dashboard as action needed rather than in progress:

    Image
  5. ievdokdm commented on Aug 17, 2026

    @ievdokdm
    Contributor

    Reset to in progress when re-run all jobs is implemented in flutter/cocoon#5117. But looks like github not properly handle that api call. it change the check run description but not change the check-run status

  6. ievdokdm commented on Aug 21, 2026

    @ievdokdm
    Contributor

    during rerun Dashboard Checks in neutral state looks less confusing

    Image
  7. jtmcdole commented on Aug 22, 2026

    @jtmcdole
    Member

    My only complaint, and we can talk about it on Monday: neutral is considered "passing" / "success". If anything waits for that checkrun, it'll get the signal "its done" when it is not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listteam-infraOwned by Infrastructure teamtriaged-infraTriaged by Infrastructure team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions