Skip to content

Consider renaming TRect::MakeEllipseBounds constructor #189464

Description

@b-luk

constexpr static TRect MakeEllipseBounds(const TPoint<Type>& center,

This constructor was originally added in #185110

See https://chat.google.com/room/AAAAK4LG52w/35DTXTELmgE/35DTXTELmgE?cls=10 for the discussion around the original naming of this constructor. It was eventually named MakeEllipseBounds.

After seeing some usages of this (#188821 (comment), #188514 (comment)), @flar suggests that we should give this a different name.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listteam-engineOwned by Engine teamtriaged-engineTriaged by Engine team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions