Skip to content

Rendered soft-hyphen glyph is excluded from selection highlight (skparagraph getRectsForRange skips hyphens) #189234

New issue
New issue
Closed
Closed
Rendered soft-hyphen glyph is excluded from selection highlight (skparagraph getRectsForRange skips hyphens)#189234
Labels
P3Issues that are less important to the Flutter projecta: text inputEntering text in a text field or keyboard related problemsa: typographyText rendering, possibly libtxtf: selectionSelectableRegion, SelectionArea, SelectionContainer, Selectable, and related APIsframeworkflutter/packages/flutter repository. See also f: labels.platform-webWeb applications specificallyteam-text-inputOwned by Text Input teamtriaged-text-inputTriaged by Text Input team

Description

@dbebawy
dbebawy
opened on Jul 10, 2026

Follow-up from #185152 (soft-hyphen rendering, part of #18443).

When Hyphens.manual renders a hyphen glyph at a soft-hyphen line break, the glyph participates in the line's width and in coordinate hit-testing, but skparagraph's getRectsForRange deliberately skips the synthetic hyphen run:

https://github.com/google/skia/blob/6d145bc3479ceda0239fb955981f67f484d5e4dd/modules/skparagraph/src/TextLine.cpp#L1237-L1243

So when a selection spans a soft-hyphen break, the visible hyphen is not included in the selection highlight, which can look surprising (the surrounding text is highlighted but the hyphen appears unselected).

The fix lives in skparagraph (include the hyphen run in getRectsForRange when renderSoftHyphens is enabled), so tracking it separately per the discussion on #185152 with @LongCatIsLooong and @Renzo-Olivares.

Activity

  1. mbcorona
    added
    a: text inputEntering text in a text field or keyboard related problems
    frameworkflutter/packages/flutter repository. See also f: labels.
    a: typographyText rendering, possibly libtxt
    f: selectionSelectableRegion, SelectionArea, SelectionContainer, Selectable, and related APIs
    team-text-inputOwned by Text Input team
    on Jul 10, 2026
  2. github-project-automation
    added this to SelectableRegion Improvementson Jul 10, 2026
  3. github-project-automation
    moved this to Incoming Issues in SelectableRegion Improvementson Jul 10, 2026
  4. mbcorona
    added
    platform-webWeb applications specifically
    team-webOwned by Web platform team
    and removed
    team-text-inputOwned by Text Input team
    on Jul 10, 2026
  5. flutter-zl
    added
    P3Issues that are less important to the Flutter project
    triaged-webTriaged by Web platform team
    on Jul 15, 2026
  6. Renzo-Olivares
    added
    fyi-text-inputFor the attention of Text Input team
    on Aug 18, 2026
  7. Renzo-Olivares
    removed this from SelectableRegion Improvementson Aug 18, 2026

  8. Renzo-Olivares commented on Aug 20, 2026

    @Renzo-Olivares
    Renzo-Olivares
    on Aug 20, 2026
    Contributor

    @flutter-zl bringing this issue to team-text-input since it is not web specific.

  9. 5 remaining items

  10. Renzo-Olivares
    removed this from SelectableRegion Improvementson Aug 20, 2026
  11. Renzo-Olivares
    removed
    fyi-text-inputFor the attention of Text Input team
    on Aug 20, 2026
  12. github-project-automation
    added this to SelectableRegion Improvementson Aug 20, 2026
  13. github-project-automation
    moved this to Incoming Issues in SelectableRegion Improvementson Aug 20, 2026
  14. flutter-triage-bot
    removed
    triaged-webTriaged by Web platform team
    on Aug 20, 2026

  15. flutter-triage-bot commented on Aug 20, 2026

    @flutter-triage-bot
    flutter-triage-botBot
    on Aug 20, 2026

    The triaged-web label is irrelevant if there is no team-web label or fyi-web label.

  16. Renzo-Olivares
    removed this from SelectableRegion Improvementson Aug 27, 2026
  17. mboetger
    added a commit that references this issue on Oct 3, 2026

    Support soft hyphen (U+00AD) rendering with a Hyphens API (flutter#18…

    3c54508
  18. hubot
    added a commit that references this issue on Oct 19, 2026

    [skparagraph] Include the rendered soft hyphen in getRectsForRange

    b41c0d6

  19. dbebawy commented on Oct 22, 2026

    @dbebawy
    dbebawy
    on Oct 22, 2026
    ContributorAuthor

    Fixed in Skia by https://skia-review.googlesource.com/c/skia/+/1396916, which rolled into Flutter in #194828. The Skia change includes tests for the selection boxes, including custom hyphen strings.

  20. dbebawy
    closed this as completedon Oct 22, 2026
  21. suryaKommana2662
    added a commit that references this issue on Oct 29, 2026

    Support soft hyphen (U+00AD) rendering with a Hyphens API (flutter#18…

    0dc5b19
  22. hubot
    added a commit that references this issue on Oct 30, 2026

    [skparagraph] Report a hit on the ellipsis or hyphen as upstream

    f326a1e

  23. github-actions commented on Nov 5, 2026

    @github-actions
    github-actionsBot
    on Nov 5, 2026 – with GitHub Actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  24. github-actions
    locked as resolved and limited conversation to collaborators on Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Issues that are less important to the Flutter projecta: text inputEntering text in a text field or keyboard related problemsa: typographyText rendering, possibly libtxtf: selectionSelectableRegion, SelectionArea, SelectionContainer, Selectable, and related APIsframeworkflutter/packages/flutter repository. See also f: labels.platform-webWeb applications specificallyteam-text-inputOwned by Text Input teamtriaged-text-inputTriaged by Text Input team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions