-
Notifications
You must be signed in to change notification settings - Fork 30.5k
package:web_benchmarks cannot find Chrome tab with benchmark app #183335
Copy link
Copy link
Closed
flutter/devtools
#9721Closed
Copy link
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listbrowser: chrome-desktoponly manifests in desktop Chromeonly manifests in desktop Chromep: web_benchmarksflutter/packages web_benchmarksflutter/packages web_benchmarkspackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.platform-webWeb applications specificallyWeb applications specificallyteam-webOwned by Web platform teamOwned by Web platform teamtriaged-webTriaged by Web platform teamTriaged by Web platform team
Metadata
Metadata
Assignees
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listbrowser: chrome-desktoponly manifests in desktop Chromeonly manifests in desktop Chromep: web_benchmarksflutter/packages web_benchmarksflutter/packages web_benchmarkspackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.platform-webWeb applications specificallyWeb applications specificallyteam-webOwned by Web platform teamOwned by Web platform teamtriaged-webTriaged by Web platform teamTriaged by Web platform team
Type
Fields
Give feedbackNo fields configured for issues without a type.
Splitting this issue out from flutter/devtools#9674, since I believe this specific flake we are seeing requires a fix in
package:web_benchmarksand not Flutter DevTools.We noticed a flake when our benchmark tests were running on Github CI (failed run):
This error is due to this tabs.single getter in
package:web_benchmarks- it expects there to be a single open http://localhost tab but for there is none.I believe the URL for the tab it is looking for is being constructed here and being opened here.
Only thing I can think is maybe Chrome is resolving
localhostas127.0.0.1and that's why the check forlocalhostisn't finding anything? (I see in the error logs above bothlocalhostand127.0.0.1)