-
Notifications
You must be signed in to change notification settings - Fork 30.5k
Non-nullable DropdownMenu is breaking change #180121
Copy link
Copy link
Closed
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listc: regressionIt was better in the past than it is nowIt was better in the past than it is nowf: material designflutter/packages/flutter/material repository.flutter/packages/flutter/material repository.found in release: 3.40Found to occur in 3.40Found to occur in 3.40frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.has reproducible stepsThe issue has been confirmed reproducible and is ready to work onThe issue has been confirmed reproducible and is ready to work onr: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer versionteam-designOwned by Design Languages teamOwned by Design Languages teamtriaged-designTriaged by Design Languages teamTriaged by Design Languages team
Metadata
Metadata
Assignees
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listc: regressionIt was better in the past than it is nowIt was better in the past than it is nowf: material designflutter/packages/flutter/material repository.flutter/packages/flutter/material repository.found in release: 3.40Found to occur in 3.40Found to occur in 3.40frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.has reproducible stepsThe issue has been confirmed reproducible and is ready to work onThe issue has been confirmed reproducible and is ready to work onr: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer versionteam-designOwned by Design Languages teamOwned by Design Languages teamtriaged-designTriaged by Design Languages teamTriaged by Design Languages team
Type
Fields
Give feedbackNo fields configured for issues without a type.
Steps to reproduce
#175090 and PR #176711 does break current implementation, since: 3.39.0-0.1.pre
An example can be found here:
#176711 (comment)
Further the type safe part of #175090 (in my opinion) does raise more problems than it actually solves. I personally don't see removing the ambiguity has any real world scenarios. In contrast the need of a null value is actually used. I don't see a concrete issue with getting the same value can result from two different events does have a negative impact (why would someone want to differentiate that, and also with this change there is not even a built-in option to differentiate.
Expected results
To either:
Actual results
The changes are breaking the below example and are a valid approach to reflect empty selection: https://material-web.dev/components/select/#usage
There are already three cases which were mentioned to break (myself included).
Code sample
Code sample
Screenshots or Video
Screenshots / Video demonstration
[Upload media here]
Logs
Logs
[Paste your logs here]Flutter Doctor output
Doctor output
[Paste your output here]