Skip to content

[packages] Run pub get in all subpackages before formatting #178072

@stuartmorgan-g

Description

@stuartmorgan-g

In flutter/packages@df0f423 we fixed an issue where dart format wasn't reliably doing the right thing (especially in CI) because pub get needs to be run to make sure the min Dart SDK version is detected correctly by dart format. Unfortunately there is an edge case where it still does the wrong thing, which is sub-packages other than example (example is handled automatically by pub get); in pigeon for instance we're currently enforcing 3.7 in CI because that's what the main package uses, but the platform_test sub-packages are set to 3.9. This causes issues for anyone who has actually built the platform tests locally since that change.

We need the repo tooling to run pub get in all subpackages of the package (ignoring example/ directories), not just at the top level.

Metadata

Metadata

Labels

P1High-priority issues at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.p: toolingAffects the flutter_plugin_tools packagepackageflutter/packages repository. See also p: labels.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions