Skip to content

(Test cross-imports) No legacy Material imports in tests #177412

Closed

Description

@justinmc

Umbrella issue: #177028
Design doc: https://docs.google.com/document/d/1UHxALQqCbmgjnM1RNV9xE2pK3IGyx-UktGX1D7hYCjs/edit?tab=t.0

Any test with a Material import that isn't strictly necessary should remove it. This will help with our general test organization and also help remove a devDependency after Material and Cupertino are decoupled from the framework.

How to fix

  1. Find a test listed below that is not already fixed (checked) and that does not have a PR already linked.
  2. Hopefully all you need to do is to remove the Material import and make sure the tests still pass.
  3. When you open a PR, reference this issue as "Part of " instead of "Fixes", to avoid it being prematurely closed.

Tests to fix:

Located in Widgets, imported Material

Located in Widgets, imported Cupertino

Located in Cupertino, imported Material

Activity

  1. added
    in triagePresently being triaged by the triage team
    a: tests"flutter test", flutter_test, or one of our tests
    frameworkflutter/packages/flutter repository. See also f: labels.
    c: proposalA detailed proposal for a change to Flutter
    and removed
    in triagePresently being triaged by the triage team
    on Oct 23, 2025
  2. self-assigned this
    on Oct 28, 2025
  3. added
    P1High-priority issues at the top of the work list
    on Oct 28, 2025
  4. moved this to In Progress in Decoupling Designon Nov 5, 2025
  5. justinmc commented on Jan 2, 2026

    @justinmc
    ContributorAuthor

    These are up for contributions now that #177029 and #178693 have merged, in case anyone wants to help migrate these! Unassigning myself.

  6. removed their assignment
    on Jan 13, 2026
  7. 70 remaining items

  8. Swiftaxe commented on Jun 23, 2026

    @Swiftaxe
    Contributor

    Hi @justinmc! I was looking to contribute to this issue and noticed that all remaining unchecked items appear to have already been resolved:

    Material import removed in #177029 for the following:

    • shrink_wrapping_viewport_test.dart
    • sensitive_content_error_handling_test.dart
    • drag_boundary_test.dart
    • sliver_fill_viewport_test.dart

    Others:

    Looks like this issue can be fully closed once the remaining checkboxes are ticked.

  9. justinmc commented on Jun 29, 2026

    @justinmc
    ContributorAuthor

    Looks like this issue is complete! Thanks so much to everyone who helped me out with these. See the main umbrella issue #177028 for more cross imports that still need fixing.

  10. moved this from In Progress to Done in Decoupling Designon Jun 29, 2026
  11. github-actions commented on Jul 14, 2026

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  12. locked as resolved and limited conversation to collaborators on Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P1High-priority issues at the top of the work lista: tests"flutter test", flutter_test, or one of our testsc: proposalA detailed proposal for a change to Flutterframeworkflutter/packages/flutter repository. See also f: labels.team-frameworkOwned by Framework teamtriaged-frameworkTriaged by Framework team

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions