-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work liste: impellerImpeller rendering backend issues and features requestsImpeller rendering backend issues and features requestsgood first issueRelatively approachable for first-time contributorsRelatively approachable for first-time contributorsteam-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team
Description
observed
There are a handful of ways loading shaders can go wrong and we don't communicate it back to the user.
Example:
| return nullptr; |
Sometimes we have VALIDATION_LOGs which will only be present in debug builds of the engine.
More failures were added in #175470
expected
I'd expect these failures to surface up to Dart exceptions so users developing with shaders get meaningful errors. Users may be developing shaders in non-debug build engines.
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work liste: impellerImpeller rendering backend issues and features requestsImpeller rendering backend issues and features requestsgood first issueRelatively approachable for first-time contributorsRelatively approachable for first-time contributorsteam-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team