☂️[a11y] Use defaultTargetPlatform instead of platform from the theme for Semantics flags in a few widgets #176566
Closed
6 of 6 issues completed
Description
Use case
I noticed this @chunhtai's comment at #173418 (comment):
"we should check defaultTargetPlatform instead of from the theme, if for some reason someone wants android feels and look on an iOS, the voice over will still be broken"
Indeed, in case users explicitly configure a specific platform (let's give it as Android for eg), but run on another platforms (let's give it as iOS for eg), accessibility might work incorrectly.
There are a few existing widgets that use platform from the theme to check:
- ExpansionTile: [a11y] Use defaultTargetPlatform instead of platform from the theme for ExpansionTile's semantic hint #177002
- Dialog: [a11y] Use defaultTargetPlatform instead of platform from the theme for Dialog's semantics #177001
- _PopupMenu: [a11y] Use defaultTargetPlatform instead of platform from the theme for PopupMenu's semantics #177003
- BottomSheet: [a11y] Use defaultTargetPlatform instead of platform from the theme for BottomSheet's semantics #177004
- Drawer: [a11y] Use defaultTargetPlatform instead of platform from the theme for Drawer's semantics #177005
Proposal
Use defaultTargetPlatform instead of using platform from the theme.
Sub-issues
Metadata
Metadata
Assignees
Labels
Accessibility, e.g. VoiceOver or TalkBack. (aka a11y)A detailed proposal for a change to FlutterTechnical debt, code quality, testing, etc.flutter/packages/flutter/material repository.flutter/packages/flutter repository. See also f: labels.Issue is closed as already fixed in a newer versionOwned by Framework Accessibility team (i.e. responsible for accessibility code in flutter/flutter)