-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Description
The new license checker parses 2 NOTICES files from devtools:
| ^third_party/dart/tools/sdks/dart-sdk/bin/resources/devtools/assets/NOTICES$ |
These appear to be recursive and should be removed. This was discovered when attempting to remove the web_unicode dependency. We would remove it from flutter/flutter, but it would still show up in the output LICENSE file because of its presence in the NOTICES file. The NOTICES file itself in the dependency appears to be generated in such a way that is recursive.
Those NOTICES files were added because the output of the old license checker was compared with the new license checker and there were seemingly licenses in the output that didn't appear anywhere but in that NOTICES file. The old license checker however explicitly excluded those NOTICES files.
After reviewing the problem here are the causes for those missing copyrights that we were getting from the NOTICES files we should be generating ourselves:
- Some licenses only existed on linux code checkouts, specifically the fuchsia licenses
- One license wasn't included because the directory had 2 licenses (
third_party/libjpeg-turbo/src/README.ijgandthird_party/libjpeg-turbo/src/LICENSE) - Some licenses just weren't getting parsed correctly, specifically the myriad of copyrights in icu.
The parsing of those NOTICES files should be removed.