Skip to content

Remove recursive license files (NOTICES) #174996

@gaaclarke

Description

@gaaclarke

The new license checker parses 2 NOTICES files from devtools:

^third_party/dart/tools/sdks/dart-sdk/bin/resources/devtools/assets/NOTICES$

These appear to be recursive and should be removed. This was discovered when attempting to remove the web_unicode dependency. We would remove it from flutter/flutter, but it would still show up in the output LICENSE file because of its presence in the NOTICES file. The NOTICES file itself in the dependency appears to be generated in such a way that is recursive.

Those NOTICES files were added because the output of the old license checker was compared with the new license checker and there were seemingly licenses in the output that didn't appear anywhere but in that NOTICES file. The old license checker however explicitly excluded those NOTICES files.

After reviewing the problem here are the causes for those missing copyrights that we were getting from the NOTICES files we should be generating ourselves:

  1. Some licenses only existed on linux code checkouts, specifically the fuchsia licenses
  2. One license wasn't included because the directory had 2 licenses (third_party/libjpeg-turbo/src/README.ijg and third_party/libjpeg-turbo/src/LICENSE)
  3. Some licenses just weren't getting parsed correctly, specifically the myriad of copyrights in icu.

The parsing of those NOTICES files should be removed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listteam-engineOwned by Engine teamtriaged-engineTriaged by Engine team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions