flutter upgrade won't run if the engine is out of date #1745

Activity

1. devoncarew

   added

   toolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.

   on Feb 9, 2016
2. devoncarew commented on Feb 9, 2016

   

   devoncarew

   on Feb 9, 2016

   ContributorAuthor

   More actions

   /cc @collinjackson
3. collinjackson commented on Feb 10, 2016

   

   collinjackson

   on Feb 10, 2016

   Contributor

   More actions

   Can you clarify what you mean by "should not include upgrade in the engine check"?
4. devoncarew commented on Feb 10, 2016

   

   devoncarew

   on Feb 10, 2016

   ContributorAuthor

   More actions

   Yup, when I ran flutter upgrade, I got an error:

   [~/flutter/flutter_sunflower] flutter upgrade
   Error: incompatible sky_engine package; please run 'pub get' to get the correct one.
   

   which pub get fixed, but my understanding is that flutter upgrade should fix the error as well. We should not include the upgrade command in the sky_engine package check.
5. collinjackson commented on Feb 10, 2016

   

   collinjackson

   on Feb 10, 2016

   Contributor

   More actions

   OK, I understand now that you mean we should not perform the sky_engine package check in the upgrade command. Makes sense!
6. collinjackson

   closed this as completedin 5cd9d5bon Feb 10, 2016
7. collinjackson

   added a commit that references this issue on Feb 10, 2016

   Merge pull request #1756 from collinjackson/upgrade_anywhere

   ...

   This issue will close once commit 96405fb is merged into the 'master' branch.

   96405fb
8. TahaTesser

   added a commit that references this issue on Aug 13, 2020

   [camera] Fix camera memory leak on IOS (flutter#1745)

   ...

   4528a65
9. github-actions commented on Sep 6, 2021

   

   github-actionsBot

   on Sep 6, 2021

   More actions

   This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
10. github-actions

    locked as resolved and limited conversation to collaborators on Sep 6, 2021