Skip to content

infra: cp1252 emoji in ci.yaml not caught till release builder #172257

Closed

Description

@jtmcdole
  • New builders were added to engine's ci.yaml
  • Builders came with some caveats and used ⚠️ in the file.
  • This was done in the year 2025. UTF-8 is reasonable and expected. Yaml "may be encoded in any one of UTF-8, UTF-16 or UTF-32." - no mention of CP1252
    ...
  • Time passes
    ...
  • New release fails on windows only builder with archaic message:
  File "C:\Users\chrome-bot\AppData\Local\vpython-root.0\store\python_venv-kkof7f3h8dmuietfo9ih9t2d5s\contents\lib\encodings\cp1252.py", line 23, in decode
    return codecs.charmap_decode(input,self.errors,decoding_table)[0]
UnicodeDecodeError: 'charmap' codec can't decode byte 0x8f in position 735: character maps to <undefined>

https://ci.chromium.org/ui/p/dart-internal/builders/flutter/Windows%20packaging_release_builder/218/overview

Activity

  1. jtmcdole commented on Jul 16, 2025

    @jtmcdole
    MemberAuthor
  2. jtmcdole commented on Jul 16, 2025

    @jtmcdole
    MemberAuthor

    Chat with Jason:

    Searching around in the recipes, it looks like https://flutter.googlesource.com/recipes/+/refs/heads/main/recipes/release/release_builder.py#190 is the only engine-related recipe that invokes this particular YAML parsing Python script.

    AFAICT other engine builds do not use it. So we would not see this error until the first time thatrelease_builder.py is run on Windows.

  3. added
    in triagePresently being triaged by the triage team
    engineflutter/engine related. See also e: labels.
    team-infraOwned by Infrastructure team
    and removed
    in triagePresently being triaged by the triage team
    on Jul 17, 2025
  4. added
    P1High-priority issues at the top of the work list
    triaged-infraTriaged by Infrastructure team
    on Jul 24, 2025
  5. self-assigned this
    on Jul 24, 2025
  6. jtmcdole commented on Jul 25, 2025

    @jtmcdole
    MemberAuthor

    I cannot wait to use emojis in all the ci yamls...

  7. matanlurey commented on Jul 25, 2025

    @matanlurey
    Contributor

    Fixed!

  8. github-actions commented on Aug 8, 2025

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  9. locked as resolved and limited conversation to collaborators on Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P1High-priority issues at the top of the work listengineflutter/engine related. See also e: labels.team-infraOwned by Infrastructure teamtriaged-infraTriaged by Infrastructure team

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions