Skip to content

unrelated formatting failures on Linux linux_unopt #171881

@gaaclarke

Description

@gaaclarke

description

I'm unable to get the Linux linux_unopt light green because of formatting failures in code that is not touched in the PR.

example

https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20Engine%20Drone/3446564/overview

log

[2025-07-09 07:43:58.394998] ERROR: ERROR: Found 124 Dart files which were formatted incorrectly.

To fix, run `et format` or:
git apply <<DONE
diff --git a/engine/src/flutter/lib/ui/key.dart b/engine/src/flutter/lib/ui/key.dart
index 4da2b8124c..0000000000 100644
--- a/engine/src/flutter/lib/ui/key.dart
+++ b/engine/src/flutter/lib/ui/key.dart
@@ -164,33 +164,34 @@ class KeyData {
String _logicalToString() {
final String result = '0x${logical.toRadixString(16)}';
final int planeNum = _nonValueBits(logical) & 0x0FF;
-    final String planeDescription = (() {
-      switch (planeNum) {
-        case 0x000:
-          return ' (Unicode)';
-        case 0x001:
-          return ' (Unprintable)';
-        case 0x002:
-          return ' (Flutter)';
-        case 0x011:
-          return ' (Android)';
-        case 0x012:
-          return ' (Fuchsia)';
-        case 0x013:
-          return ' (iOS)';
-        case 0x014:
-          return ' (macOS)';
-        case 0x015:
-          return ' (GTK)';
-        case 0x016:
-          return ' (Windows)';
-        case 0x017:
-          return ' (Web)';
-        case 0x018:
-          return ' (GLFW)';
-      }
-      return '';

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listteam-engineOwned by Engine teamtriaged-engineTriaged by Engine team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions