-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listc: new featureNothing broken; request for a new capabilityNothing broken; request for a new capabilityinfra: releaseRelease-related requests and toolingRelease-related requests and toolingteam-infraOwned by Infrastructure teamOwned by Infrastructure team
Description
For releases, we often need to update the bin/internal/engine.version file to a newest SHA referencing a commit that includes all the changes (including relevant cherry-picks) that we want to include in the release. However, this SHA can only reference a change that actually includes engine changes. We should consider adding a presubmit test that (1) checks if the SHA that we choose includes an engine change and if not, (2) warns if an older SHA should be used to reference a change with engine modifications/if it doesn't need to modified at all (I assume this is a case we could fall into for hotfix releases but I may be wrong).
CC @matanlurey as this was inspired by my mistakes in #169952, fixed by #170005
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listc: new featureNothing broken; request for a new capabilityNothing broken; request for a new capabilityinfra: releaseRelease-related requests and toolingRelease-related requests and toolingteam-infraOwned by Infrastructure teamOwned by Infrastructure team