Skip to content

Consider adding a presubmit check for updates to engine.version #170012

@camsim99

Description

@camsim99

For releases, we often need to update the bin/internal/engine.version file to a newest SHA referencing a commit that includes all the changes (including relevant cherry-picks) that we want to include in the release. However, this SHA can only reference a change that actually includes engine changes. We should consider adding a presubmit test that (1) checks if the SHA that we choose includes an engine change and if not, (2) warns if an older SHA should be used to reference a change with engine modifications/if it doesn't need to modified at all (I assume this is a case we could fall into for hotfix releases but I may be wrong).

CC @matanlurey as this was inspired by my mistakes in #169952, fixed by #170005

Metadata

Metadata

Assignees

Labels

P2Important issues not at the top of the work listc: new featureNothing broken; request for a new capabilityinfra: releaseRelease-related requests and toolingteam-infraOwned by Infrastructure team

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions