-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listc: regressionIt was better in the past than it is nowIt was better in the past than it is nowteam-toolOwned by Flutter Tool teamOwned by Flutter Tool team
Description
In 3.32, .flutter-plugins is no longer emitted:
However, the crash reporting feature in the flutter tool was hard-coded to read/use that file:
flutter/packages/flutter_tools/lib/src/reporting/github_template.dart
Lines 146 to 161 in fa37785
| final File file = project.flutterPluginsFile; | |
| if (file.existsSync()) { | |
| description.writeln('### Plugins'); | |
| // Format is: | |
| // camera=/path/to/.pub-cache/hosted/pub.dartlang.org/camera-0.5.7+2/ | |
| for (final String plugin in project.flutterPluginsFile.readAsLinesSync()) { | |
| final List<String> pluginParts = plugin.split('='); | |
| if (pluginParts.length != 2) { | |
| continue; | |
| } | |
| // Write the last part of the path, which includes the plugin name and version. | |
| // Example: camera-0.5.7+2 | |
| final List<String> pathParts = _fileSystem.path.split(pluginParts[1]); | |
| description.writeln(pathParts.isEmpty ? pluginParts.first : pathParts.last); | |
| } | |
| } |
This needs to be re-written to use .flutter-plugins-dependencies, and probably cherry-picked into 3.32/3.33.
Metadata
Metadata
Assignees
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listc: regressionIt was better in the past than it is nowIt was better in the past than it is nowteam-toolOwned by Flutter Tool teamOwned by Flutter Tool team