Skip to content

Restore DDC Expression Evaluation tests (#168017): Causing suite timeouts #169304

@matanlurey

Description

@matanlurey

#168017 significantly added time to {PLATFORM} web_tool_tests, causing timeouts:

https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.prod/Mac%20web_tool_tests
https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.prod/Linux%20web_tool_tests
Also #169277

Image

Looking at a single execution:

24:45 +36 ~10: /b/s/w/ir/x/w/flutter/packages/flutter_tools/test/web.shard/expression_evaluation_web_amd_test.dart: Flutter test for web can evaluate complex expressions in a test
25:25 +37 ~10: /b/s/w/ir/x/w/flutter/packages/flutter_tools/test/web.shard/expression_evaluation_web_amd_test.dart: Flutter test for web evaluated expression includes correctly mapped stack trace
26:07 +38 ~10: /b/s/w/ir/x/w/flutter/packages/flutter_tools/test/web.shard/expression_evaluation_web_amd_test.dart: Flutter test for web evaluated expression includes web library environment defines
26:45 +39 ~10: /b/s/w/ir/x/w/flutter/packages/flutter_tools/test/web.shard/expression_evaluation_web_amd_test.dart: Flutter test for web can evaluate trivial expressions in a test
27:23 +40 ~10: /b/s/w/ir/x/w/flutter/packages/flutter_tools/test/web.shard/expression_evaluation_web_amd_test.dart: Flutter test for web cannot evaluate expressions if feature is disabled
28:01 +41 ~10: /b/s/w/ir/x/w/flutter/packages/flutter_tools/test/web.shard/expression_evaluation_web_amd_test.dart: Flutter test for web can evaluate complex expressions in library without pause
28:38 +42 ~10: /b/s/w/ir/x/w/flutter/packages/flutter_tools/test/web.shard/expression_evaluation_web_amd_test.dart: Flutter test for web can evaluate trivial expressions in library without pause
29:17 +43 ~10: /b/s/w/ir/x/w/flutter/packages/flutter_tools/test/web.shard/expression_evaluation_web_amd_test.dart: Flutter run for web can evaluate complex expressions in build method
29:52 +44 ~10: /b/s/w/ir/x/w/flutter/packages/flutter_tools/test/web.shard/expression_evaluation_web_amd_test.dart: Flutter run for web cannot evaluate expression if feature is disabled
30:26 +45 ~10: /b/s/w/ir/x/w/flutter/packages/flutter_tools/test/web.shard/expression_evaluation_web_amd_test.dart: Flutter run for web can evaluate trivial expressions in library without pause
31:01 +46 ~10: /b/s/w/ir/x/w/flutter/packages/flutter_tools/test/web.shard/expression_evaluation_web_amd_test.dart: Flutter run for web can evaluate complex expressions in top level function
31:35 +47 ~10: /b/s/w/ir/x/w/flutter/packages/flutter_tools/test/web.shard/expression_evaluation_web_amd_test.dart: Flutter run for web evaluated expression includes web library environment defines
32:10 +48 ~10: /b/s/w/ir/x/w/flutter/packages/flutter_tools/test/web.shard/expression_evaluation_web_amd_test.dart: Flutter run for web can evaluate trivial expressions in top level function
32:45 +49 ~10: /b/s/w/ir/x/w/flutter/packages/flutter_tools/test/web.shard/expression_evaluation_web_amd_test.dart: Flutter run for web can handle compilation errors
33:20 +50 ~10: /b/s/w/ir/x/w/flutter/packages/flutter_tools/test/web.shard/expression_evaluation_web_amd_test.dart: Flutter run for web evaluated expression includes correctly mapped stack trace
33:58 +51 ~10: /b/s/w/ir/x/w/flutter/packages/flutter_tools/test/web.shard/expression_evaluation_web_amd_test.dart: Flutter run for web can evaluate trivial expressions in build method
34:32 +52 ~10: /b/s/w/ir/x/w/flutter/packages/flutter_tools/test/web.shard/expression_evaluation_web_amd_test.dart: Flutter run for web can evaluate complex expressions in library without pause
35:06 +53 ~10: /b/s/w/ir/x/w/flutter/packages/flutter_tools/test/web.shard/expression_evaluation_web_amd_test.dart: Flutter run for web shows no native javascript objects in static scope

One test suite (there are two of the above PR) takes over 10 minutes.

Metadata

Metadata

Labels

P0Critical issues such as a build break or regressionc: disabled testTracks the restoration of a disabled testfyi-toolFor the attention of Flutter Tool teamteam-webOwned by Web platform team

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions