Skip to content

[Impeller] libImpeller: Make the impeller.hpp classes non-final. #168394

@chinmaygarde

Description

@chinmaygarde

When these were first written, it was assumed that the classes would be used purely from C++. However, bindings to environments like Python can be easily written against the C++ API. But the classes being final makes it hard to add environment specific functionality. Bindings authors could use composition but that requires all callsites to annotated differently which makes the whole process more tedious.

The C++ classes are also just wrappers over a handle to the underlying Impeller type.

Metadata

Metadata

Assignees

No one assigned

    Labels

    e: impellerImpeller rendering backend issues and features requestse: libimpellerThe standalone Impeller library with a single-header API.engineflutter/engine related. See also e: labels.r: fixedIssue is closed as already fixed in a newer versionteam-engineOwned by Engine team

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions