-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Copy link
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listinfra: releaseRelease-related requests and toolingRelease-related requests and toolingteam-infraOwned by Infrastructure teamOwned by Infrastructure teamtriaged-infraTriaged by Infrastructure teamTriaged by Infrastructure team
Description
There a number of human-verified steps in our release process.
One example is that bin/internal/engine.version should be set to the last commit SHA that modified the engine, but specifically before making a [packed] release, as it has no (practical) effect before then. That's an easy step to either forget, forget to update, etc.
There was previously such a lint, but it was disabled when we moved over to a monorepo:
recipes/release/release_publish.py
There were also utilities in the past in our recipes that did Git commit-like checks:
In theory it should be possible to restore this check.
It would even be better to surface this earlier, i.e. before running the packaging step.
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listinfra: releaseRelease-related requests and toolingRelease-related requests and toolingteam-infraOwned by Infrastructure teamOwned by Infrastructure teamtriaged-infraTriaged by Infrastructure teamTriaged by Infrastructure team