-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Closed
Copy link
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listslimpellerEngine binary size reduction. go/slimpellerEngine binary size reduction. go/slimpellerteam-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team
Description
ci/android_release_slimpeller_arm64 maps to the same GCS paths as android-arm64-release and thus can step on binary outputs of other builders.
flutter/engine/src/flutter/ci/builders/linux_android_aot_engine.json
Lines 167 to 174 in 5bd0fb7
| "base_path": "out/ci/android_release_slimpeller_arm64/zip_archives/", | |
| "include_paths": [ | |
| "out/ci/android_release_slimpeller_arm64/zip_archives/android-arm64-release/artifacts.zip", | |
| "out/ci/android_release_slimpeller_arm64/zip_archives/android-arm64-release/linux-x64.zip", | |
| "out/ci/android_release_slimpeller_arm64/zip_archives/android-arm64-release/symbols.zip", | |
| "out/ci/android_release_slimpeller_arm64/zip_archives/android-arm64-release/analyze-snapshot-linux-x64.zip", | |
| "out/ci/android_release_slimpeller_arm64/zip_archives/download.flutter.io" | |
| ], |
Mitigating by removing the config in #168178
See this comment for suggested fix: #168178 (comment)
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listslimpellerEngine binary size reduction. go/slimpellerEngine binary size reduction. go/slimpellerteam-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team
Type
Projects
Status
Done