Skip to content

Initial release branch presubmit will *always* fail due to licensing check #166807

@matanlurey

Description

@matanlurey

In #166783, I started a new release branch.

One component of making a release branch is pinning to a specific Dart commit SHA:

Image

However, that will always cause the Linux licensing (engine) check to fail, because it references the Dart SHA:

Image

The license test can only be run on a Linux machine, which most Flutter engineers do not use day-to-day, so they either need to remember (and use) a Linux machine, or they need to push, wait for the engine to build and for the license test to run (wasting resources otherwise), and copy the resulting Signature: ... in order to make progress.

The easiest thing to do would be able to regenerate the licenses golden on a Mac. @jtmcdole mentioned it might work now?

/cc @reidbaker

Metadata

Metadata

Assignees

Labels

P2Important issues not at the top of the work lista: annoyanceRepeatedly frustrating issues with non-experimental functionalityinfra: releaseRelease-related requests and toolingteam-infraOwned by Infrastructure teamtriaged-infraTriaged by Infrastructure team

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions