-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
flutter/packages
#8999Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.p: google_identity_services_webA JS-interop layer for Google Identity's Sign In With Google SDKA JS-interop layer for Google Identity's Sign In With Google SDKpackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.platform-webWeb applications specificallyWeb applications specificallyteam-webOwned by Web platform teamOwned by Web platform teamtriaged-webTriaged by Web platform teamTriaged by Web platform team
Description
The current implementation of the maybeEnum method throws when the needle value is unexpected, but it should return null instead. This particular plugin is "vulnerable" to this because the GIS API is somewhat in flux, and we've had other enums fail before.
This could be rewritten to be more similar to the google_adsense version, so it withstands (and maybe logs) unknown enum values.
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.p: google_identity_services_webA JS-interop layer for Google Identity's Sign In With Google SDKA JS-interop layer for Google Identity's Sign In With Google SDKpackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.platform-webWeb applications specificallyWeb applications specificallyteam-webOwned by Web platform teamOwned by Web platform teamtriaged-webTriaged by Web platform teamTriaged by Web platform team