-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listc: new featureNothing broken; request for a new capabilityNothing broken; request for a new capabilityc: proposalA detailed proposal for a change to FlutterA detailed proposal for a change to Flutterf: material designflutter/packages/flutter/material repository.flutter/packages/flutter/material repository.frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.team-designOwned by Design Languages teamOwned by Design Languages teamtriaged-designTriaged by Design Languages teamTriaged by Design Languages team
Description
Use case
I am showing a dialog using the Dialog.fullscreen constructor, but when I do it and I have an AppBar inside the dialog, then the AppBar will show a BackButton and not a CloseButton.
This happens because the AppBar automatically selects it's button based on parentRoute.fullscreenDialog, which showDialog nor showGeneralDialog set to true, since they don't create a PageRoute but a RawDialogRoute that doesn't have this flag available.
Proposal
showDialog and it's variants like showGeneralDialog should have an optional parameter fullscreenDialog that can be forwarded (and added) to RawDialogRoute and DialogRoute, so the AppBar could automatically detect if it's current route is a full-screen one.
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listc: new featureNothing broken; request for a new capabilityNothing broken; request for a new capabilityc: proposalA detailed proposal for a change to FlutterA detailed proposal for a change to Flutterf: material designflutter/packages/flutter/material repository.flutter/packages/flutter/material repository.frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.team-designOwned by Design Languages teamOwned by Design Languages teamtriaged-designTriaged by Design Languages teamTriaged by Design Languages team