-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed as duplicate of#79681
Closed as duplicate of#79681
Copy link
Labels
P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter projecta: buildBuilding flutter applications with the toolBuilding flutter applications with the toolc: new featureNothing broken; request for a new capabilityNothing broken; request for a new capabilityc: proposalA detailed proposal for a change to FlutterA detailed proposal for a change to Flutterteam-toolOwned by Flutter Tool teamOwned by Flutter Tool teamtoolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.triaged-toolTriaged by Flutter Tool teamTriaged by Flutter Tool team
Description
Use case
Support running Flutter apps in profile or release mode on a custom device.
The Flutter profile build mode is very useful for troubleshooting performance issues, but trying to run a Flutter app in profile or release mode on a custom device currently fails with:
$ flutter run -d my-device --profile
Profile mode is not supported by <My device>.Proposal
Add support for running Flutter apps in profile and release modes on custom devices by:
- Removing the hard-coded
debugmode check fromCustomDevice::supportsRuntimeMode
flutter/packages/flutter_tools/lib/src/custom_devices/custom_device.dart
Lines 681 to 684 in d8100ac
@override FutureOr<bool> supportsRuntimeMode(BuildMode buildMode) { return buildMode == BuildMode.debug; } - Adding a new
${buildMode}string interpolation variable to therunDebugcommand (or possibly rename the command toruninstead?):
flutter/packages/flutter_tools/lib/src/custom_devices/custom_device.dart
Lines 351 to 356 in d8100ac
final List<String> interpolated = interpolateCommand(_device._config.runDebugCommand, <String, String>{ 'remotePath': '/tmp/', 'appName': packageName, 'engineOptions': _getEngineOptionsForCmdline(debuggingOptions, traceStartup, route), });
Metadata
Metadata
Assignees
Labels
P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter projecta: buildBuilding flutter applications with the toolBuilding flutter applications with the toolc: new featureNothing broken; request for a new capabilityNothing broken; request for a new capabilityc: proposalA detailed proposal for a change to FlutterA detailed proposal for a change to Flutterteam-toolOwned by Flutter Tool teamOwned by Flutter Tool teamtoolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.triaged-toolTriaged by Flutter Tool teamTriaged by Flutter Tool team