-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work lista: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testsc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.team-androidOwned by Android platform teamOwned by Android platform team
Description
#163711 attempted to fix #163706, but broke Linux android_release_builds_exclude_dev_dependencies_test:
[2025-02-20 09:41:14.538210] [STDOUT] ══╡ ••• Check that the release build includes Flutter embedding as a direct dependency ••• ╞══
[2025-02-20 09:41:14.538250] [STDOUT]
[2025-02-20 09:41:14.548399] [STDOUT] Checking for reboot
[2025-02-20 09:41:14.549349] [STDOUT] Executing "/b/s/w/ir/cache/android/sdk/platform-tools/adb devices -l" in "/b/s/w/ir/x/w/rc/tmppur2_4jo/flutter sdk/dev/devicelab" with environment {BOT: true, LANG: en_US.UTF-8}
[2025-02-20 09:41:14.558052] [STDOUT] stdout: List of devices attached
[2025-02-20 09:41:14.558147] [STDOUT] stdout:
[android_release_builds_exclude_dev_dependencies_test] Process terminated with exit code 0.
Task result:
{
"success": false,
"reason": "Expected to find the Flutter embedding as a dependency of the release app build, but did not."
}Two problems:
android_release_builds_exclude_dev_dependencies_testhas too strict of arunIf(should have run in presubmit)- I should not break this test
Metadata
Metadata
Assignees
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work lista: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testsc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.team-androidOwned by Android platform teamOwned by Android platform team