Skip to content

macos_content_validation_test fails with --explicit-pacakge-dependencies #163706

@matanlurey

Description

@matanlurey

Example failure from #160289:

01:06 +1 -1: test/host_cross_arch.shard/macos_content_validation_test.dart: flutter build macos --debug builds a valid app [E]
  Expected: not contains 'Running pod install'
    Actual: 'Running pod install...                                             621ms\n'
              'Building macOS application...                                   \n'
              'Detected macOS app running in CI, turning off sandboxing.\n'
              '✓ Built build/macos/Build/Products/Debug/Flutter Gallery.app\n'
              ''

It can be fixed locally with the following patch:

diff --git a/packages/flutter_tools/lib/src/flutter_plugins.dart b/packages/flutter_tools/lib/src/flutter_plugins.dart
index 3d11a0cf4b..b3eb0e34e2 100644
--- a/packages/flutter_tools/lib/src/flutter_plugins.dart
+++ b/packages/flutter_tools/lib/src/flutter_plugins.dart
@@ -94,7 +94,7 @@ Future<List<Plugin>> findPlugins(
   bool throwOnError = true,
   bool? determineDevDependencies,
 }) async {
-  determineDevDependencies ??= featureFlags.isExplicitPackageDependenciesEnabled;
+  determineDevDependencies ??= false;
   final List<Plugin> plugins = <Plugin>[];
   final FileSystem fs = project.directory.fileSystem;
   final File packageConfigFile = findPackageConfigFileOrDefault(project.directory);

Metadata

Metadata

Assignees

Labels

P1High-priority issues at the top of the work listfyi-toolFor the attention of Flutter Tool teamteam-iosOwned by iOS platform teamtoolAffects the "flutter" command-line tool. See also t: labels.

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions