Skip to content

generate_gradle_lockfiles.dart creates new (unchecked) files #163228

@matanlurey

Description

@matanlurey

At HEAD, do the following:

dart dev/tools/bin/generate_gradle_lockfiles.dart

Lockfiles are generated for dev/integration_tests/display_cutout_rotation/android:

create mode 100644 dev/integration_tests/display_cutout_rotation/android/buildscript-gradle.lockfile
create mode 100644 dev/integration_tests/display_cutout_rotation/android/project-app.lockfile
create mode 100644 dev/integration_tests/display_cutout_rotation/android/project-integration_test.lockfile

I would have expected either:

  • A test to be failing, because we're missing a lockfile;
  • These files not to be generated, because they aren't tested.

This is disruptive because I have to now either manually delete the files, or think really hard (TM) about including in them in a completely unrelated PR.

Metadata

Metadata

Assignees

Labels

P1High-priority issues at the top of the work lista: tests"flutter test", flutter_test, or one of our testsplatform-androidAndroid applications specificallyteam-androidOwned by Android platform team

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions