Skip to content

Treat "tree status" as a required check unless emergency is present #162715

@matanlurey

Description

@matanlurey

Today, we have many, many people merging PRs directly in ways that (often unintentionally) bypass the "tree status" check:

... in fact, it's easier to find PRs that ignore "auto submit" than PRs that use "auto submit".

This is sort of our own fault, we can't control the UX of Github, and a giant green button that says "Add to Merge Queue" is never going to be understandable as a "Actually, Add to Merge Queue in a way that skips Tree Status Checks, so Probably Don't Do This". We should start treating "tree status" as a required check, ignoring it only for emergency labeled PRs.

I am marking this a P0 as we should mitigate this ASAP, we've just gotten lucky so far it hasn't meant cascading breakages.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P1High-priority issues at the top of the work listteam-infraOwned by Infrastructure teamtriaged-infraTriaged by Infrastructure team

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions