-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listteam-androidOwned by Android platform teamOwned by Android platform team
Description
#160354 added dev/integration_tests/display_cutout_rotation, but there is no place on CI where it is being executed, so this is (in practical terms) unused code, or a manual-only test (whatever you prefer). As a related artifact, it is now blocking dev/tools/bin/generate_gradle_lockfiles.dart because of some configuration or parsing error:
$ dart ./dev/tools/bin/generate_gradle_lockfiles.dart
...
Processing /Users/matanl/Developer/flutter/dev/integration_tests/display_cutout_rotation/android
Unhandled exception:
ProcessException: Starting a Gradle Daemon, 2 incompatible Daemons could not be reused, use --status for details
w: file:///Users/matanl/Developer/flutter/dev/integration_tests/display_cutout_rotation/android/settings.gradle.kts:14:34: The expression is unused
e: file:///Users/matanl/Developer/flutter/dev/integration_tests/display_cutout_rotation/android/settings.gradle.kts:10:24: Expecting an element
e: file:///Users/matanl/Developer/flutter/dev/integration_tests/display_cutout_rotation/android/settings.gradle.kts:11:24: Expecting an element
e: file:///Users/matanl/Developer/flutter/dev/integration_tests/display_cutout_rotation/android/settings.gradle.kts:13:28: Expecting an element
e: file:///Users/matanl/Developer/flutter/dev/integration_tests/display_cutout_rotation/android/settings.gradle.kts:13:40: Expecting an element
e: file:///Users/matanl/Developer/flutter/dev/integration_tests/display_cutout_rotation/android/settings.gradle.kts:14:31: Expecting an element
e: file:///Users/matanl/Developer/flutter/dev/integration_tests/display_cutout_rotation/android/settings.gradle.kts:14:33: Unexpected tokens (use ';' to separate expressions on the same line)
e: file:///Users/matanl/Developer/flutter/dev/integration_tests/display_cutout_rotation/android/settings.gradle.kts:14:38: Unexpected tokens (use ';' to separate expressions on the same line)We should either (quickly, ~next PR) fix this, or revert #160354 until it can be properly added.
Metadata
Metadata
Assignees
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listteam-androidOwned by Android platform teamOwned by Android platform team