Skip to content

doctor_test.dart uses GroupedValidator in tests which reports real execution times #161918

@bkonyi

Description

@bkonyi

This can result in flakiness when running on slower machines like our test infrastructure.

Example failure from logs:

06:22 +308 ~2: test/commands.shard/hermetic/doctor_test.dart: doctor with grouped validators validate merging assigns statusInfo and title
Expected: '[✓] First validator title (A status message) [0ms]\n'
            '    • A helpful message\n'
            '    • A different message\n'
            '\n'
            '• No issues found!\n'
            ''
  Actual: '[✓] First validator title (A status message) [1ms]\n'
            '    • A helpful message\n'
            '    • A different message\n'
            '\n'
            '• No issues found!\n'
            ''
   Which: is different.
          Expected: ... message) [0ms]\n     ...
            Actual: ... message) [1ms]\n     ...
                                  ^
           Differ at offset 46

#0      fail (package:matcher/src/expect/expect.dart:149:31)
#1      _expect (package:matcher/src/expect/expect.dart:144:3)
#2      expect (package:matcher/src/expect/expect.dart:56:3)
#3      main.<anonymous closure>.<anonymous closure> (file:///Volumes/Work/s/w/ir/x/w/flutter/packages/flutter_tools/test/commands.shard/hermetic/doctor_test.dart:710:7)
<asynchronous suspension>
#4      testUsingContext.<anonymous closure>.<anonymous closure>.<anonymous closure>.<anonymous closure>.<anonymous closure> (file:///Volumes/Work/s/w/ir/x/w/flutter/packages/flutter_tools/test/src/context.dart:151:32)
<asynchronous suspension>
#5      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:154:19)
<asynchronous suspension>
#6      testUsingContext.<anonymous closure>.<anonymous closure>.<anonymous closure>.<anonymous closure> (file:///Volumes/Work/s/w/ir/x/w/flutter/packages/flutter_tools/test/src/context.dart:140:28)
<asynchronous suspension>

Metadata

Metadata

Assignees

Labels

P1High-priority issues at the top of the work listtoolAffects the "flutter" command-line tool. See also t: labels.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions