Skip to content

Gradle Wrapper-related files in Flutter Gradle Plugin sources should be either commited or gitignored #161480

@bartekpacia

Description

@bartekpacia

When working on packages/fluter_tools/gradle in IntelliJ, I always end up with:

$ git status
On branch master
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
packages/flutter_tools/gradle/gradle/
packages/flutter_tools/gradle/gradlew
packages/flutter_tools/gradle/gradlew.bat

no changes added to commit (use "git add" and/or "git commit -a")

We should either:
1 commit these files to git (will require some exemption because binary files generally aren't allowed to be committed, see here)
2. add them to .gitignore so they stop showing up

I'm somewhat partial to option (1) because it'd ensure we use the same Gradle version for developing the Flutter Gradle Plugin. No strong opinion, though.

cc @gmackall @reidbaker

Metadata

Metadata

Assignees

Labels

P1High-priority issues at the top of the work listc: proposalA detailed proposal for a change to Flutterplatform-androidAndroid applications specificallyt: gradle"flutter build" and "flutter run" on Androidteam-androidOwned by Android platform teamtoolAffects the "flutter" command-line tool. See also t: labels.triaged-androidTriaged by Android platform team

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions