[packages][tool] make-deps-path-based should sort dependency overrides #160810
Description
The camera/camera/example app had the following dependency override:
dependency_overrides:
camera_web:
path: ../../camera_web
When running dart flutter_plugin_tools.dart make-deps-path-based --current-package --target-dependencies=camera_android_camerax on the branch of this PR, the script produced the following changes:
diff --git a/packages/camera/camera/example/pubspec.yaml b/packages/camera/camera/example/pubspec.yaml
index 9f3749514..66087e5b4 100644
--- a/packages/camera/camera/example/pubspec.yaml
+++ b/packages/camera/camera/example/pubspec.yaml
@@ -28,9 +28,15 @@ dev_dependencies:
integration_test:
sdk: flutter
+
+# FOR TESTING AND INITIAL REVIEW ONLY. DO NOT MERGE.
+# See https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changing-federated-plugins
dependency_overrides:
+
camera_web:
path: ../../camera_web
+ camera_android_camerax:
+ path: ../../../../packages/camera/camera_android_camerax
flutter:
uses-material-design: trueThat change is invalid, because it breaks our sort_pub_dependencies lint:
Finding changed packages relative to "cebedf87bf381c605850b7c5e04c580396e3666e"...
Rewriting references to: camera_android_camerax...
Modified packages/camera/camera/pubspec.yaml
Running for all packages that have uncommitted changes
Changed packages: camera/camera
[0:00] Running for packages/camera/camera...
Running command: "flutter pub get" in /b/s/w/ir/x/w/packages/packages/camera/camera
Resolving dependencies...
Downloading packages...
+ ... list of deps
Changed 56 dependencies!
12 packages have newer versions incompatible with dependency constraints.
Try `flutter pub outdated` for more information.
Resolving dependencies in `./example`...
Downloading packages...
Got dependencies in `./example`.
Running command: "dart analyze --fatal-infos" in /b/s/w/ir/x/w/packages/packages/camera/camera
Analyzing camera...
info - example/pubspec.yaml:38:3 - Dependencies not sorted alphabetically. Try sorting the dependencies alphabetically (A to Z). - sort_pub_dependencies
1 issue found.
The following packages had errors:
packages/camera/camera
Should the tool sort the pubspec after modifying it?