Skip to content

Remove WebGoldenComparator #160261

@matanlurey

Description

@matanlurey

Update: It is now deprecated. When the HTML backend is removed, it can also be removed.


There are two interfaces with nearly identical roles in flutter_test:

The latter is only used in a web browser/web context, and the former is used otherwise.

For the workstream that will be making package:integration_test be able to take and compare screenshots, even on mobile devices (i.e. Android and iOS), we'll be bleeding the lines further - using GoldenFileComparator as a proxy, which coincidentally is almost exactly what WebGoldenComparator does.

Here is a draft PR where I do exactly that: #160131.

It would be nice for flutter_test to have a cleaner interface, and not have a web and non-web configuration. The interfaces are nearly identical. I've initially assigned this to team-framework as owners of flutter_test to give a reaction; feel free to reach out to me directly to discuss further.

Metadata

Metadata

Assignees

Labels

P2Important issues not at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.team-webOwned by Web platform teamtriaged-webTriaged by Web platform team

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions