Skip to content

Prepare to enable explicit-package-dependencies #160257

@matanlurey

Description

@matanlurey

This flag gates the new "label plugins as dev_dependencies" feature, as well as deprecates two old features:

As of the time of this writing flutter_tools/test/general.shard has 100+ tests that fail with this flag enabled, mostly because they use compute_dev_dependencies transitively, and a fake Pub instance is not hooked up. I have yet to try the other test suites, but likely some fail in commands.shard and integration.shard.

Two options:

  1. Opt failing tests out explicitly (turn off the feature), turn the feature on, work through failing tests
  2. Fix failing tests before turning on the feature (opt-them in early)

Will chat with @bkonyi and @andrewkolos to figure out what they prefer.

My intuition is (2) leaves us in a better incremental state. Here is an example: #160258.


TODOs

  • Update test/commands.shard/permeable/create_test.dart (and templates/skeleton)
    Potentially also a bug in lib/src/dart/generate_synthetic_packages.dart

Metadata

Metadata

Assignees

Labels

P1High-priority issues at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.team-toolOwned by Flutter Tool team

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions