-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.packageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.team-ecosystemOwned by Ecosystem teamOwned by Ecosystem teamtriaged-ecosystemTriaged by Ecosystem teamTriaged by Ecosystem team
Description
In my experience doing Pigeon conversions of our plugins, dartHostTestHandler didn't make tests noticeably easier than simply mocking/faking/stubbing the host API class directly, and in some cases it was actually harder to use correctly to simulate things like exceptions. We have a robust test suite for Pigeon itself, so having package-level unit tests covering part of the Pigeon serialization isn't necessary, and the test generator is another generator we need to maintain.
We should try to eliminate all use of dartHostTestHandler in our own plugins, and if we are able to do so without any significant issues, remove the test generator from Pigeon entirely to reduce complexity and ongoing maintenance costs.
Current usage:
-
camera_android_camerax -
file_selector_ios[file_selector] Remove use of Pigeon's Dart test generator packages#10315 -
file_selector_linux[file_selector] Remove use of Pigeon's Dart test generator packages#10315 -
file_selector_macos[file_selector] Remove use of Pigeon's Dart test generator packages#10315 -
file_selector_windows[file_selector] Remove use of Pigeon's Dart test generator packages#10315 -
image_picker_android[image_picker] Remove use of Pigeon's Dart test generator packages#10320 -
image_picker_ios[image_picker] Remove use of Pigeon's Dart test generator packages#10320 -
in_app_purchase_storekit[in_app_purchase] Remove use of Pigeon's Dart test generator packages#10328 -
path_provider_android[path_provider] Remove use of Pigeon's Dart test generator packages#10323 -
path_provider_foundation[path_provider] Remove use of Pigeon's Dart test generator packages#10323 -
shared_preferences_android[shared_preferences] Remove use of Pigeon's Dart test generator packages#10325 -
shared_preferences_foundation[shared_preferences] Remove use of Pigeon's Dart test generator packages#10325 -
url_launcher_windows[url_launcher] Remove unused dartHostTestHandler packages#10324 -
video_player_android -
video_player_avfoundation -
webview_flutter_wkwebview
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.packageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.team-ecosystemOwned by Ecosystem teamOwned by Ecosystem teamtriaged-ecosystemTriaged by Ecosystem teamTriaged by Ecosystem team