Skip to content

[packages] Eliminate use of Pigeon dartHostTestHandler #159886

@stuartmorgan-g

Description

@stuartmorgan-g

In my experience doing Pigeon conversions of our plugins, dartHostTestHandler didn't make tests noticeably easier than simply mocking/faking/stubbing the host API class directly, and in some cases it was actually harder to use correctly to simulate things like exceptions. We have a robust test suite for Pigeon itself, so having package-level unit tests covering part of the Pigeon serialization isn't necessary, and the test generator is another generator we need to maintain.

We should try to eliminate all use of dartHostTestHandler in our own plugins, and if we are able to do so without any significant issues, remove the test generator from Pigeon entirely to reduce complexity and ongoing maintenance costs.

Current usage:

Metadata

Metadata

Labels

P2Important issues not at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.packageflutter/packages repository. See also p: labels.team-ecosystemOwned by Ecosystem teamtriaged-ecosystemTriaged by Ecosystem team

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions