[flutter_svg] SvgNetworkLoader never closes internal HTTP client #158928
Description
Steps to reproduce
- Create a
SvgNetworkLoaderinstance, without passing it a custom http client - Call
prepareMessage(), which will create an internal client - The created client is never calling its
close()method
3a. I had hoped to demonstrate this with a test that enables leak tracking, but the HTTP client does not register itself with the memory allocations tooling
Expected results
The client is closed at the end of postMessage()
Actual results
If the SvgNetworkLoader is not provided with a client, its internal client is not cleaned up.
Code sample
Code sample
import 'package:flutter_svg/svg.dart';
void main() async {
const String url =
'https://raw.githubusercontent.com/flutter/packages/b9ac917daeb0fbf5bd6ad4a7d2a69ab81749d767/third_party/packages/flutter_svg/example/assets/flutter_logo.svg';
const SvgNetworkLoader loader = SvgNetworkLoader(url);
await loader.prepareMessage(null);
}Screenshots or Video
Screenshots / Video demonstration
[Upload media here]
Logs
Logs
[Paste your logs here]Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.24.3, on macOS 14.6.1 23G93 darwin-x64, locale en-BE)
• Flutter version 3.24.3 on channel stable at /Users/navaronbracke/Documents/flutter
• Upstream repository [email protected]:navaronbracke/flutter.git
• FLUTTER_GIT_URL = [email protected]:navaronbracke/flutter.git
• Framework revision 2663184aa7 (9 weeks ago), 2024-09-11 16:27:48 -0500
• Engine revision 36335019a8
• Dart version 3.5.3
• DevTools version 2.37.3
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
• Android SDK at /Users/navaronbracke/Library/Android/sdk
• Platform android-34, build-tools 34.0.0
• ANDROID_HOME = /Users/navaronbracke/Library/Android/sdk
• Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 17.0.11+0-17.0.11b1207.24-11852314)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 16.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Build 16B40
• CocoaPods version 1.15.2
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2024.1)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 17.0.11+0-17.0.11b1207.24-11852314)
[✓] VS Code (version 1.95.2)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.100.0
[✓] Connected device (2 available)
• macOS (desktop) • macos • darwin-x64 • macOS 14.6.1 23G93 darwin-x64
• Chrome (web) • chrome • web-javascript • Google Chrome 131.0.6778.69
[✓] Network resources
• All expected network resources are available.
• No issues found!