Skip to content

flutter build "apk" succeeds without libraries from native_assets_without_cbuild_assemble_test.dart is slow and flaky #158560

Closed

Activity

  1. added
    c: flakeTests that sometimes, but not always, incorrectly pass
    P0Critical issues such as a build break or regression
    team-toolOwned by Flutter Tool team
    on Nov 13, 2024
  2. bkonyi commented on Nov 13, 2024

    @bkonyi
    Contributor

    There's only been 36 runs on this configuration, so the reported flaky rate may be slightly higher than the actual rate.

    It looks like flutter build "apk" succeeds without libraries in native_assets_without_cbuild_assemble_test.dart is failing due to a timeout and an unexpected exit code from Gradle.

    I'm assigning this to @matanlurey (who recently rewrote this test) and @dcharkes (who owns native asset functionality) to investigate further.

  3. changed the title [-]Linux tool_integration_tests_6_6 is 6.25% flaky[/-] [+]`flutter build "apk" succeeds without libraries` from `native_assets_without_cbuild_assemble_test.dart` is slow and flaky[/+] on Nov 13, 2024
  4. matanlurey commented on Nov 13, 2024

    @matanlurey
    Contributor

    I think a no-brainer move is to just disable the apk variant of the tests for now, the actual functionality being tested by this is specific for macOS, and while it would be great to have more coverage I wouldn't even know where to start in terms of debugging why this specific test configuration times out (maybe hidden Java heap issues?)

  5. matanlurey commented on Nov 13, 2024

    @matanlurey
    Contributor

    I also wonder if this is similar to @andrewkolos' other investigations (i.e. #157847) where it appears that flutter build apk can just take wildly different amounts of time or #152604 where OOMs are the cause.

  6. matanlurey commented on Nov 13, 2024

    @matanlurey
    Contributor

    Interestingly enough android_plugin_example_app_build_test.dart which otherwise is doing something very similar, does not appear to have this problem. The only difference I can see is the AGP version being used?

  7. matanlurey commented on Nov 13, 2024

    @matanlurey
    Contributor

    As of #158757 I am going to watch this build for the rest of the day - if it is extra bad I can disable and create a bringup shard so it doesn't disrupt the rest of the team.

  8. matanlurey commented on Nov 13, 2024

    @matanlurey
    Contributor

    Failed again, here is the output:

    Running [/b/s/w/ir/x/w/flutter/bin/flutter, build, linux, --debug]...
    Downloading linux-x64-debug/linux-x64-flutter-gtk tools...       1,306ms
    Downloading linux-x64-profile/linux-x64-flutter-gtk tools...        511ms
    Downloading linux-x64-release/linux-x64-flutter-gtk tools...        466ms
    
    Building Linux application...                                   
    ✓ Built build/linux/x64/debug/bundle/uses_package_native_assets_cli
    16:43 +88: test/integration.shard/isolated/native_assets_without_cbuild_assemble_test.dart: flutter build "apk" succeeds without libraries
    Running [/b/s/w/ir/x/w/flutter/bin/flutter, build, apk, --debug]...
    Resolving dependencies...
    Downloading packages...
      characters 1.3.0 (1.3.1 available)
      collection 1.19.0 (1.19.1 available)
      matcher 0.12.16+1 (0.12.17 available)
      material_color_utilities 0.11.1 (0.12.0 available)
      meta 1.15.0 (1.16.0 available)
    Got dependencies!
    5 packages have newer versions incompatible with dependency constraints.
    Try `flutter pub outdated` for more information.
    
    Running Gradle task 'assembleDebug'...
  9. 6 remaining items

  10. matanlurey commented on Nov 15, 2024

    @matanlurey
    Contributor

    I am adding more skips, and also trying to reproduce the failures on a bringup shard.

  11. dcharkes commented on Nov 18, 2024

    @dcharkes
    Contributor

    Thanks for picking this up @matanlurey while I was out! 🙏

    Unfortunately as #158879 shows, the failures are not specific to native_assets.

    Since you're on it, and it's not native assets specific, I'll go ahead and unassign myself. Please let me know if you need me. ☎️

  12. removed their assignment
    on Nov 18, 2024
  13. added
    P0Critical issues such as a build break or regression
    and removed
    P1High-priority issues at the top of the work list
    on Nov 20, 2024
  14. github-actions commented on Dec 5, 2024

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  15. locked as resolved and limited conversation to collaborators on Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P0Critical issues such as a build break or regressionc: disabled testTracks the restoration of a disabled testc: flakeTests that sometimes, but not always, incorrectly passteam-toolOwned by Flutter Tool teamteam: skip-testAn issue used to track tests that are skipped.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions