-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
flutter/engine
#56432Closed
Copy link
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.team-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team
Description
I was debugging a failure reported on a presubmit CI that looks like this:
Command run successfully in 0.80 seconds: /b/s/w/ir/cache/builder/src/out/ci/host_debug/exe.unstripped/flutter_tester --disable-observatory --enable-impeller --use-test-fonts --icu-data-file-path=/b/s/w/ir/cache/builder/src/out/ci/host_debug/icudtl.dat --flutter-assets-dir=/b/s/w/ir/cache/builder/src/out/ci/host_debug/gen/flutter/lib/ui/assets --disable-asset-fonts /b/s/w/ir/cache/builder/src/out/ci/host_debug/gen/lerp_test.dart.dill (in /b/s/w/ir/cache/builder/src)
00:00 �[32m+0�[0m: color accessors should work�[0m
00:00 �[32m+1�[0m: paint set to black�[0m
00:00 �[32m+1�[0m: paint set to black�[0m
00:00 �[32m+2�[0m: color created with out of bounds value�[0m
00:00 �[32m+2�[0m: color created with out of bounds value�[0m
00:00 �[32m+3�[0m: color created with wildly out of bounds value�[0m
00:00 �[32m+3�[0m: color created with wildly out of bounds value�[0m
00:00 �[32m+4�[0m: two colors are only == if they have the same runtime type�[0m
00:00 �[32m+4�[0m: two colors are only == if they have the same runtime type�[0m
00:00 �[32m+5�[0m: Color.lerp�[0mIgnoring the fact that the ANSI escapes probably should not be here, when run locally:
/Users/matanl/Developer/engine/src/out/host_debug/flutter_tester /Users/matanl/Developer/engine/src/out/host_debug/gen/color_test.dart.dill
The Dart VM service is listening on http://127.0.0.1:63537/LqlqLQrYue4=/
00:00 +0: color accessors should work
00:00 +1: paint set to black... and then that's it, i.e. there is no output beyond paint set to black.
This is a regression as a result of me upgrading these tests to use package:test. I haven't observed this behavior before, so it's probably a combination of having flutter-tester invoke these tests (versus dart test).
Metadata
Metadata
Assignees
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.team-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team