Skip to content

[Impeller] MoltenVK and triangle fans usage in Vulkan needs workarounds. #158024

Closed
flutter-team-archive/engine
#56321

Description

@chinmaygarde

Super low priority. On the Mac, there must be a cap check for the triangle primitive topology when the portability subset extension is enabled (which SwiftShader wont enable by Molten will). Otherwise, there will be rendering errors.

--- Vulkan Debug Report  ----------------------------------------
|                Severity: Error
|                    Type: { Validation }
|                 ID Name: VUID-VkPipelineInputAssemblyStateCreateInfo-triangleFans-04452
|               ID Number: 1316858618
|       Queue Breadcrumbs: [NONE]
|  CMD Buffer Breadcrumbs: [NONE]
|                 Trigger: Validation Error: [ VUID-VkPipelineInputAssemblyStateCreateInfo-triangleFans-04452 ] | MessageID = 0x4e7daafa | vkCreateGraphicsPipelines(): pCreateInfos[0] (portability error): VK_PRIMITIVE_TOPOLOGY_TRIANGLE_FAN is not supported. The Vulkan spec states: If the VK_KHR_portability_subset extension is enabled, and VkPhysicalDevicePortabilitySubsetFeaturesKHR::triangleFans is VK_FALSE, topology must not be VK_PRIMITIVE_TOPOLOGY_TRIANGLE_FAN (https://vulkan.lunarg.com/doc/view/1.3.280.0/mac/1.3-extensions/vkspec.html#VUID-VkPipelineInputAssemblyStateCreateInfo-triangleFans-04452)
-----------------------------------------------------------------

Activity

  1. added
    e: impellerImpeller rendering backend issues and features requests
    on Nov 1, 2024
  2. jonahwilliams commented on Nov 1, 2024

    @jonahwilliams
    Contributor

    Lets just ifdef it out on macOS?

  3. added
    P2Important issues not at the top of the work list
    on Nov 4, 2024
  4. github-actions commented on Nov 20, 2024

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  5. locked as resolved and limited conversation to collaborators on Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work liste: impellerImpeller rendering backend issues and features requeststeam-engineOwned by Engine teamtriaged-engineTriaged by Engine team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions