-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Open
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.team-iosOwned by iOS platform teamOwned by iOS platform teamtriaged-iosTriaged by iOS platform teamTriaged by iOS platform team
Description
In a typical iOS and macOS project NSAsserts are off in release mode. Here's the ENABLE_NS_ASSERTIONS build setting in a newly created project:
Controls whether assertion logic provided by NSAssert is included in the preprocessed source code or is elided during preprocessing. Disabling assertions can improve code performance.
flutter/buildroot#860 attempted to turn off asserts in release mode, however there were some analyzer errors when it was rolled into the engine, so the buildroot commit was reverted.
Fix the analyzer errors, then reland flutter/buildroot#860 to turn off ENABLE_NS_ASSERTIONS in Release mode.
Examples of NSAssert crashes that probably shouldn't be happening in #148279
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.team-iosOwned by iOS platform teamOwned by iOS platform teamtriaged-iosTriaged by iOS platform teamTriaged by iOS platform team
