Skip to content

[vector_graphics] review package API and publish new versions. #157626

Closed
flutter/packages
#8018

Description

@jonahwilliams

Format stability has been achieved mostly via not changing the API for N years. Document this explicitly and declare the package 1.0

Activity

  1. stuartmorgan-g commented on Oct 25, 2024

    @stuartmorgan-g
    Contributor

    and declare the package 1.0

    That will be tricky since they are all on 1.1.11+1 :)

  2. jonahwilliams commented on Oct 25, 2024

    @jonahwilliams
    ContributorAuthor

    well, something like that :)

    1.5!

  3. changed the title [-][vector_graphics] review package API and publish 1.0 versions[/-] [+][vector_graphics] review package API and publish new versions.[/+] on Oct 25, 2024
  4. stuartmorgan-g commented on Oct 28, 2024

    @stuartmorgan-g
    Contributor

    Capturing from offline discussion to provide more context here: in the past, vector_graphics* has use exact, pinned dependencies between the different versions, and special release logic that ensures they are all published in dependency order. Both of these would require a bunch of custom work in our repo, and it sounds like we don't need that level of tight coupling any more.

    For now I'm importing with almost-exactly-pinned versions (allowing both the last pre-import and the first post-import version, but nothing else) to preserve existing behavior, with comments referencing this issue in the pubspec, but very soon we should replace those contraints with something based on the plan going forward. My strong preference would be to apply semver, as even setting aside the tooling aspects, having a small number of packages in a repo with many, many other packages that follows weird special rules that anyone touching the package has to know about is a significant maintenance burden.

  5. added
    P2Important issues not at the top of the work list
    on Oct 28, 2024
  6. stuartmorgan-g commented on Nov 1, 2024

    @stuartmorgan-g
    Contributor

    flutter/packages#7991 changed the version of only one package, so things are now mis-aligned. If the solution doesn't end up being to use semver, that will need to be addressed.

  7. github-actions commented on Nov 19, 2024

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  8. locked as resolved and limited conversation to collaborators on Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P2Important issues not at the top of the work listp: vector_graphicsThe vector_graphics package setteam-engineOwned by Engine teamtriaged-engineTriaged by Engine team

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions