We can get around the reactor queueing and resolve it immediately by posting a raster task.
But this is only necessary when a new pipeline actually needs to be created. Need to add a way to check for the presence of a pipeline in the library without triggering a new pipeline creation.

@@ -134,8 +140,27 @@ RenderPass::GetOrCreatePipeline() {
   render_pipeline_->BindToPipelineDescriptor(*context.GetShaderLibrary(),
                                              pipeline_desc);

-  auto pipeline =
-      context.GetPipelineLibrary()->GetPipeline(pipeline_desc).Get();
+  std::shared_ptr<impeller::Pipeline<impeller::PipelineDescriptor>> pipeline;
+
+  if (context.GetBackendType() == impeller::Context::BackendType::kOpenGLES) {
+    // Get the pipeline on the raster thread.
+    auto dart_state = flutter::UIDartState::Current();
+    std::promise<
+        std::shared_ptr<impeller::Pipeline<impeller::PipelineDescriptor>>>
+        pipeline_promise;
+    auto pipeline_future = pipeline_promise.get_future();
+    fml::TaskRunner::RunNowOrPostTask(
+        dart_state->GetTaskRunners().GetRasterTaskRunner(),
+        fml::MakeCopyable([promise = std::move(pipeline_promise),
+                           context = GetContext(), pipeline_desc]() mutable {
+          promise.set_value(
+              context->GetPipelineLibrary()->GetPipeline(pipeline_desc).Get());
+        }));
+    pipeline = pipeline_future.get();
+  } else {
+    pipeline = context.GetPipelineLibrary()->GetPipeline(pipeline_desc).Get();
+  }
+
   FML_DCHECK(pipeline) << "Couldn't resolve render pipeline";
   return pipeline;
 }

Next issue is with shader compilation:

[ERROR:flutter/impeller/renderer/backend/gles/pipeline_library_gles.cc(74)] Break on 'ImpellerValidationBreak' to inspect point of failure: Failed to compile vertex shader for '' with error:
ERROR: 0:1: '120' : client/version number not supported

Shader source was:
#version 120
#ifdef GL_ARB_shading_language_420pack
#extension GL_ARB_shading_language_420pack : require
#endif

struct FrameInfo
{
    mat4 mvp;
    vec4 color;
};

uniform FrameInfo frame_info;

varying vec4 v_color;
attribute vec2 position;

void main()
{
    v_color = frame_info.color;
    gl_Position = frame_info.mvp * vec4(position, 0.0, 1.0);
    gl_Position.z = 2.0 * gl_Position.z - gl_Position.w;
}

[Flutter GPU] Windows: UI thread hangs indefinitely on RenderPass::Draw. #156305

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions