Skip to content

iOS Flakes after FlutterEngine ARC migration #156177

New issue
New issue
Closed
Closed
iOS Flakes after FlutterEngine ARC migration#156177
Assignees
cbracken
Labels
a: tests"flutter test", flutter_test, or one of our testsc: flakeTests that sometimes, but not always, incorrectly passplatform-iosiOS applications specifically
@cbracken

Description

@cbracken
cbracken
opened on Oct 3, 2024

Test logs:

Test Case '-[FlutterKeyboardManagerTest testEventsProcessedSequentially]' started.
[ERROR:flutter/fml/memory/thread_checker.h(78)] Object referenced on a thread other than the one on which it was created. Expected thread: ''. Actual thread: ''.
[FATAL:flutter/fml/memory/weak_ptr.h(282)] Check failed: (checker_.checker).IsCreationThreadCurrent().

Crash on thread 7:

(lldb) bt
* thread #7, queue = 'com.apple.root.background-qos', stop reason = signal SIGABRT
    frame #0: 0x0000000100b0d008 libsystem_kernel.dylib`__pthread_kill + 8
    frame #1: 0x0000000100d6b408 libsystem_pthread.dylib`pthread_kill + 256
    frame #2: 0x000000018016c4ec libsystem_c.dylib`abort + 104
  * frame #3: 0x000000010e29f11c libios_test_flutter.dylib`fml::KillProcess() at logging.cc:221:3
    frame #4: 0x000000010e29f0f8 libios_test_flutter.dylib`fml::LogMessage::~LogMessage(this=0x000000016f94a8a0) at logging.cc:208:5
    frame #5: 0x000000010e29f138 libios_test_flutter.dylib`fml::LogMessage::~LogMessage(this=0x000000016f94a8a0) at logging.cc:133:27
    frame #6: 0x000000010d7379c4 libios_test_flutter.dylib`fml::WeakPtrFactory<flutter::PlatformViewsController>::CheckThreadSafety(this=0x00000001089990e0) const at weak_ptr.h:282:5
    frame #7: 0x000000010d7378a8 libios_test_flutter.dylib`fml::WeakPtrFactory<flutter::PlatformViewsController>::~WeakPtrFactory(this=0x00000001089990e0) at weak_ptr.h:265:5
    frame #8: 0x000000010d73787c libios_test_flutter.dylib`fml::WeakPtrFactory<flutter::PlatformViewsController>::~WeakPtrFactory(this=0x00000001089990e0) at weak_ptr.h:264:21
    frame #9: 0x000000010d737820 libios_test_flutter.dylib`std::_fl::default_delete<fml::WeakPtrFactory<flutter::PlatformViewsController>>::operator()[abi:v15000](this=0x00000001020c55c8, __ptr=0x00000001089990e0) const at unique_ptr.h:48:5
    frame #10: 0x000000010d73779c libios_test_flutter.dylib`std::_fl::unique_ptr<fml::WeakPtrFactory<flutter::PlatformViewsController>, std::_fl::default_delete<fml::WeakPtrFactory<flutter::PlatformViewsController>>>::reset[abi:v15000](this=0x00000001020c55c8, __p=0x0000000000000000) at unique_ptr.h:305:7
    frame #11: 0x000000010d73772c libios_test_flutter.dylib`std::_fl::unique_ptr<fml::WeakPtrFactory<flutter::PlatformViewsController>, std::_fl::default_delete<fml::WeakPtrFactory<flutter::PlatformViewsController>>>::~unique_ptr[abi:v15000](this=0x00000001020c55c8) at unique_ptr.h:259:19
    frame #12: 0x000000010d7374ec libios_test_flutter.dylib`std::_fl::unique_ptr<fml::WeakPtrFactory<flutter::PlatformViewsController>, std::_fl::default_delete<fml::WeakPtrFactory<flutter::PlatformViewsController>>>::~unique_ptr[abi:v15000](this=0x00000001020c55c8) at unique_ptr.h:259:17
    frame #13: 0x000000010d7373f8 libios_test_flutter.dylib`flutter::PlatformViewsController::~PlatformViewsController(this=0x00000001020c5400) at platform_views_controller.h:35:38
    frame #14: 0x000000010d7373c8 libios_test_flutter.dylib`flutter::PlatformViewsController::~PlatformViewsController(this=0x00000001020c5400) at platform_views_controller.h:35:38
    frame #15: 0x000000010d9a24a4 libios_test_flutter.dylib`std::_fl::default_delete<flutter::PlatformViewsController>::operator()[abi:v15000](this=0x0000000108eb5098, __ptr=0x00000001020c5400) const at unique_ptr.h:48:5
    frame #16: 0x000000010d9a22ac libios_test_flutter.dylib`std::_fl::__shared_ptr_pointer<flutter::PlatformViewsController*, std::_fl::shared_ptr<flutter::PlatformViewsController>::__shared_ptr_default_delete<flutter::PlatformViewsController, flutter::PlatformViewsController>, std::_fl::allocator<flutter::PlatformViewsController>>::__on_zero_shared(this=0x0000000108eb5080) at shared_ptr.h:263:5
    frame #17: 0x000000010d6899e8 libios_test_flutter.dylib`std::_fl::__shared_count::__release_shared[abi:v15000](this=0x0000000108eb5080) at shared_ptr.h:174:9
    frame #18: 0x000000010d68998c libios_test_flutter.dylib`std::_fl::__shared_weak_count::__release_shared[abi:v15000](this=0x0000000108eb5080) at shared_ptr.h:215:27
    frame #19: 0x000000010d68a144 libios_test_flutter.dylib`std::_fl::shared_ptr<flutter::PlatformViewsController>::~shared_ptr[abi:v15000](this=0x0000000108fa8338) at shared_ptr.h:702:23
    frame #20: 0x000000010d689e50 libios_test_flutter.dylib`std::_fl::shared_ptr<flutter::PlatformViewsController>::~shared_ptr[abi:v15000](this=0x0000000108fa8338) at shared_ptr.h:700:5
    frame #21: 0x000000010d99e14c libios_test_flutter.dylib`-[FlutterEngine .cxx_destruct](self=0x0000000108fa8300, _cmd=".cxx_destruct") at FlutterEngine.mm:129:17
    frame #22: 0x000000018006a844 libobjc.A.dylib`object_cxxDestructFromClass(objc_object*, objc_class*) + 112
    frame #23: 0x00000001800833ac libobjc.A.dylib`objc_destructInstance + 76
    frame #24: 0x00000001804cd1a8 CoreFoundation`-[NSObject(NSObject) __dealloc_zombie] + 148
    frame #25: 0x000000010d990afc libios_test_flutter.dylib`-[FlutterEngine dealloc](self=0x0000000108fa8300, _cmd="dealloc") at FlutterEngine.mm:306:1
    frame #26: 0x000000010d694d8c libios_test_flutter.dylib`__destroy_helper_block_ea8_32s40s((null)=0x0000000109581740) at FlutterEngineTest.mm:0
    frame #27: 0x00000001800f6edc libsystem_blocks.dylib`_call_dispose_helpers_excp + 44
    frame #28: 0x00000001800f7d24 libsystem_blocks.dylib`_Block_release + 300
    frame #29: 0x0000000180178de0 libdispatch.dylib`_dispatch_client_callout + 16
    frame #30: 0x000000018018b7dc libdispatch.dylib`_dispatch_root_queue_drain + 1072
    frame #31: 0x000000018018bf60 libdispatch.dylib`_dispatch_worker_thread2 + 232
    frame #32: 0x0000000100d67b38 libsystem_pthread.dylib`_pthread_wqthread + 224

Test on thread 1:

* thread #1, queue = 'com.apple.main-thread'
    frame #0: 0x0000000100b05290 libsystem_kernel.dylib`mach_msg2_trap + 8
    frame #1: 0x0000000100b166c4 libsystem_kernel.dylib`mach_msg2_internal + 76
    frame #2: 0x0000000100b0d3f4 libsystem_kernel.dylib`mach_msg_overwrite + 536
    frame #3: 0x0000000100b055cc libsystem_kernel.dylib`mach_msg + 20
    frame #4: 0x000000018041ab60 CoreFoundation`__CFRunLoopServiceMachPort + 156
    frame #5: 0x0000000180415224 CoreFoundation`__CFRunLoopRun + 1160
    frame #6: 0x0000000180414960 CoreFoundation`CFRunLoopRunSpecific + 536
    frame #7: 0x000000010d9b22d4 libios_test_flutter.dylib`-[FlutterKeyboardManager handlePress:nextAction:](self=0x000000010a4205d0, _cmd="handlePress:nextAction:", press=0x0000000108fde0d0, next=0x000000010d6b3bb8) at FlutterKeyboardManager.mm:99:7
    frame #8: 0x000000010d6b3bac libios_test_flutter.dylib`__61-[FlutterKeyboardManagerTest testEventsProcessedSequentially]_block_invoke.110(.block_descriptor=0x0000000109581080, timerRef=0x0000000109769dc0) at FlutterKeyboardManagerTest.mm:267:9
    frame #9: 0x000000018041ba2c CoreFoundation`__CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ + 28
    frame #10: 0x000000018041b6e8 CoreFoundation`__CFRunLoopDoTimer + 956
    frame #11: 0x000000018041ad7c CoreFoundation`__CFRunLoopDoTimers + 284
    frame #12: 0x00000001804154a8 CoreFoundation`__CFRunLoopRun + 1804
    frame #13: 0x0000000180414960 CoreFoundation`CFRunLoopRunSpecific + 536
    frame #14: 0x0000000180415850 CoreFoundation`CFRunLoopRun + 60
  * frame #15: 0x000000010d6b2dac libios_test_flutter.dylib`-[FlutterKeyboardManagerTest testEventsProcessedSequentially](self=0x0000000106431cc0, _cmd="testEventsProcessedSequentially") at FlutterKeyboardManagerTest.mm:308:3
    frame #16: 0x00000001804bdcc0 CoreFoundation`__invoking___ + 144
    frame #17: 0x00000001804bac34 CoreFoundation`-[NSInvocation invoke] + 276
    frame #18: 0x0000000101116ac4 XCTestCore`+[XCTFailableInvocation invokeStandardConventionInvocation:completion:] + 64
    frame #19: 0x0000000101116a7c XCTestCore`__90+[XCTFailableInvocation invokeInvocation:withTestMethodConvention:lastObservedErrorIssue:]_block_invoke_3 + 24
    frame #20: 0x00000001011162e8 XCTestCore`__81+[XCTFailableInvocation invokeWithAsynchronousWait:lastObservedErrorIssue:block:]_block_invoke + 300
    frame #21: 0x00000001010fc4d4 XCTestCore`__49+[XCTSwiftErrorObservation observeErrorsInBlock:]_block_invoke + 28
    frame #22: 0x00000001014c6dfc libXCTestSwiftSupport.dylib`reabstraction thunk helper from @callee_unowned @convention(block) () -> () to @escaping @callee_guaranteed () -> () + 16
    frame #23: 0x00000001014c6c5c libXCTestSwiftSupport.dylib`closure #1 () -> () in static __C.XCTSwiftErrorObservation._observeErrors(in: () -> ()) -> () -> Swift.Optional<XCTest.XCTIssue> + 48
    frame #24: 0x00000001014c6fa8 libXCTestSwiftSupport.dylib`partial apply forwarder for closure #1 () -> () in static __C.XCTSwiftErrorObservation._observeErrors(in: () -> ()) -> () -> Swift.Optional<XCTest.XCTIssue> + 28
    frame #25: 0x00000002444a2f5c libswift_Concurrency.dylib`Swift.TaskLocal.withValue<τ_0_0>(_: τ_0_0, operation: () throws -> τ_1_0, file: Swift.String, line: Swift.UInt) throws -> τ_1_0 + 128
    frame #26: 0x00000001014c6a98 libXCTestSwiftSupport.dylib`static __C.XCTSwiftErrorObservation._observeErrors(in: () -> ()) -> () -> Swift.Optional<XCTest.XCTIssue> + 488
    frame #27: 0x00000001014c6d70 libXCTestSwiftSupport.dylib`@objc static __C.XCTSwiftErrorObservation._observeErrors(in: () -> ()) -> () -> Swift.Optional<XCTest.XCTIssue> + 84
    frame #28: 0x00000001010fc3d0 XCTestCore`+[XCTSwiftErrorObservation observeErrorsInBlock:] + 160
    frame #29: 0x00000001011160c8 XCTestCore`+[XCTFailableInvocation invokeWithAsynchronousWait:lastObservedErrorIssue:block:] + 184
    frame #30: 0x00000001011167cc XCTestCore`+[XCTFailableInvocation invokeInvocation:withTestMethodConvention:lastObservedErrorIssue:] + 432
    frame #31: 0x0000000101116b50 XCTestCore`+[XCTFailableInvocation invokeInvocation:lastObservedErrorIssue:] + 68
    frame #32: 0x00000001010d3268 XCTestCore`__24-[XCTestCase invokeTest]_block_invoke.80 + 96
    frame #33: 0x00000001010d86dc XCTestCore`-[XCTestCase(XCTIssueHandling) _caughtUnhandledDeveloperExceptionPermittingControlFlowInterruptions:caughtInterruptionException:whileExecutingBlock:] + 160
    frame #34: 0x00000001010d2df8 XCTestCore`-[XCTestCase invokeTest] + 660
    frame #35: 0x00000001010d486c XCTestCore`__26-[XCTestCase performTest:]_block_invoke.118 + 32
    frame #36: 0x00000001010d86dc XCTestCore`-[XCTestCase(XCTIssueHandling) _caughtUnhandledDeveloperExceptionPermittingControlFlowInterruptions:caughtInterruptionException:whileExecutingBlock:] + 160
    frame #37: 0x00000001010d42ac XCTestCore`__26-[XCTestCase performTest:]_block_invoke.108 + 492
    frame #38: 0x00000001010b37a4 XCTestCore`+[XCTContext _runInChildOfContext:forTestCase:markAsReportingBase:block:] + 172
    frame #39: 0x00000001010b36a4 XCTestCore`+[XCTContext runInContextForTestCase:markAsReportingBase:block:] + 100
    frame #40: 0x00000001010d3d58 XCTestCore`-[XCTestCase performTest:] + 248
    frame #41: 0x00000001010cffac XCTestCore`-[XCTest runTest] + 44
    frame #42: 0x00000001010decec XCTestCore`-[XCTestSuite runTestBasedOnRepetitionPolicy:testRun:] + 64
    frame #43: 0x00000001010deb70 XCTestCore`__27-[XCTestSuite performTest:]_block_invoke + 160
    frame #44: 0x00000001010de5f8 XCTestCore`__59-[XCTestSuite _performProtectedSectionForTest:testSection:]_block_invoke + 40
    frame #45: 0x00000001010b37a4 XCTestCore`+[XCTContext _runInChildOfContext:forTestCase:markAsReportingBase:block:] + 172
    frame #46: 0x00000001010b36a4 XCTestCore`+[XCTContext runInContextForTestCase:markAsReportingBase:block:] + 100
    frame #47: 0x00000001010de574 XCTestCore`-[XCTestSuite _performProtectedSectionForTest:testSection:] + 152
    frame #48: 0x00000001010de81c XCTestCore`-[XCTestSuite performTest:] + 192
    frame #49: 0x00000001010cffac XCTestCore`-[XCTest runTest] + 44
    frame #50: 0x00000001010decec XCTestCore`-[XCTestSuite runTestBasedOnRepetitionPolicy:testRun:] + 64
    frame #51: 0x00000001010deb70 XCTestCore`__27-[XCTestSuite performTest:]_block_invoke + 160
    frame #52: 0x00000001010de5f8 XCTestCore`__59-[XCTestSuite _performProtectedSectionForTest:testSection:]_block_invoke + 40
    frame #53: 0x00000001010b37a4 XCTestCore`+[XCTContext _runInChildOfContext:forTestCase:markAsReportingBase:block:] + 172
    frame #54: 0x00000001010b36a4 XCTestCore`+[XCTContext runInContextForTestCase:markAsReportingBase:block:] + 100
    frame #55: 0x00000001010de574 XCTestCore`-[XCTestSuite _performProtectedSectionForTest:testSection:] + 152
    frame #56: 0x00000001010de81c XCTestCore`-[XCTestSuite performTest:] + 192
    frame #57: 0x00000001010cffac XCTestCore`-[XCTest runTest] + 44
    frame #58: 0x00000001010decec XCTestCore`-[XCTestSuite runTestBasedOnRepetitionPolicy:testRun:] + 64
    frame #59: 0x00000001010deb70 XCTestCore`__27-[XCTestSuite performTest:]_block_invoke + 160
    frame #60: 0x00000001010de5f8 XCTestCore`__59-[XCTestSuite _performProtectedSectionForTest:testSection:]_block_invoke + 40
    frame #61: 0x00000001010b37a4 XCTestCore`+[XCTContext _runInChildOfContext:forTestCase:markAsReportingBase:block:] + 172
    frame #62: 0x00000001010b36a4 XCTestCore`+[XCTContext runInContextForTestCase:markAsReportingBase:block:] + 100
    frame #63: 0x00000001010de574 XCTestCore`-[XCTestSuite _performProtectedSectionForTest:testSection:] + 152
    frame #64: 0x00000001010de81c XCTestCore`-[XCTestSuite performTest:] + 192
    frame #65: 0x00000001010cffac XCTestCore`-[XCTest runTest] + 44
    frame #66: 0x00000001010fd6c4 XCTestCore`__89-[XCTTestRunSession executeTestsWithIdentifiers:skippingTestsWithIdentifiers:completion:]_block_invoke + 100
    frame #67: 0x00000001010b37a4 XCTestCore`+[XCTContext _runInChildOfContext:forTestCase:markAsReportingBase:block:] + 172
    frame #68: 0x00000001010b36a4 XCTestCore`+[XCTContext runInContextForTestCase:markAsReportingBase:block:] + 100
    frame #69: 0x00000001010fd58c XCTestCore`-[XCTTestRunSession executeTestsWithIdentifiers:skippingTestsWithIdentifiers:completion:] + 252
    frame #70: 0x00000001010f0690 XCTestCore`__72-[XCTExecutionWorker enqueueTestIdentifiersToRun:testIdentifiersToSkip:]_block_invoke_2 + 120
    frame #71: 0x00000001010f1864 XCTestCore`__XCTAsyncEnumerateWithWaiter_block_invoke + 224
    frame #72: 0x00000001010f19fc XCTestCore`__XCTAsyncEnumerate_block_invoke.98 + 52
    frame #73: 0x00000001010f0510 XCTestCore`XCTAsyncEnumerateWithWaiter + 500
    frame #74: 0x00000001010f02d0 XCTestCore`__72-[XCTExecutionWorker enqueueTestIdentifiersToRun:testIdentifiersToSkip:]_block_invoke + 108
    frame #75: 0x00000001010f07c4 XCTestCore`-[XCTExecutionWorker runWithError:] + 76
    frame #76: 0x00000001010ee808 XCTestCore`__25-[XCTestDriver _runTests]_block_invoke.200 + 52
    frame #77: 0x00000001011025f8 XCTestCore`-[XCTestObservationCenter _observeTestExecutionForTestBundle:inBlock:] + 180
    frame #78: 0x00000001010ee1f4 XCTestCore`-[XCTestDriver _runTests] + 1088
    frame #79: 0x00000001010eff90 XCTestCore`_XCTestMain + 116
    frame #80: 0x0000000100a87168 libXCTestBundleInject.dylib`RunTestsFromRunLoop + 116
    frame #81: 0x00000001803e3d88 CoreFoundation`__CFMachPortPerform + 172
    frame #82: 0x000000018041ba6c CoreFoundation`__CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE1_PERFORM_FUNCTION__ + 56
    frame #83: 0x000000018041b034 CoreFoundation`__CFRunLoopDoSource1 + 496
    frame #84: 0x0000000180415628 CoreFoundation`__CFRunLoopRun + 2188
    frame #85: 0x0000000180414960 CoreFoundation`CFRunLoopRunSpecific + 536
    frame #86: 0x0000000190183b10 GraphicsServices`GSEventRunModal + 160
    frame #87: 0x0000000185aa2b40 UIKitCore`-[UIApplication _run] + 796
    frame #88: 0x0000000185aa6d38 UIKitCore`UIApplicationMain + 124
    frame #89: 0x00000001007fa4d4 IosUnitTests`main(argc=2, argv=0x000000016f6055b0) at main.m:10:12
    frame #90: 0x000000010080d410 dyld_sim`start_sim + 20
    frame #91: 0x000000010090e274 dyld`start + 2840

ui, raster, io, profiler, io.worker threads are idle.

Metadata

Metadata

Assignees

Labels

a: tests"flutter test", flutter_test, or one of our testsc: flakeTests that sometimes, but not always, incorrectly passplatform-iosiOS applications specifically

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions