Skip to content

Verify that dart test has acceptable semantics for engine CI #155950

@matanlurey

Description

@matanlurey

Forked from flutter/engine#55475 some questions that shouldn't be buried on that PR.

I'm not sure what to do with this information (maybe there is an ask for the engine team to improve the infra or file downstream bugs?), but filing this for posterity to divorce it from merging flutter/engine#55475 (which is unrelated to adding dart test, dart test already runs on engine CI).


Does dart test do an implicit pub get?

Yes.

Do we need a flag to skip implicit pub gets for dart test?

Unclear (based on the discussion so far), leaning no.

Does dart test write to the source tree at all?

Yes, since we consider .gitignore'd directories - .dart_tool/test.

Do we need to isolate dart test in a way where it doesn't write to the source tree?

Unclear (based on the discussion so far), leaning no.

Does dart test send telemetry? Should we be explicitly disabling that on CI, somehow?

package:unified_analytics detect if we're running on CI and disable telemetry automatically

Is it possible to ensure that no other process connects to a compilation server?

Yes, with --resident-compiler-info-file

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.engineflutter/engine related. See also e: labels.team-engineOwned by Engine teamtriaged-engineTriaged by Engine team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions