Skip to content

flutter doctor should consider symlink #155474

Closed

Description

@FMorschel

Steps to reproduce

When using puro(GitHub) to manage flutter versions, I ran into an issue.

It uses symlink so that if you have different environments (different names) that are all the same Flutter/Dart version, it symlinks them to the same version to make sure you only have one version installed on the machine to reduce used space.

If you add one Flutter environment from it to the path, and also one Dart SDK, here is the output when running flutter doctor -v:

[!] Flutter (Channel stable, 3.24.3, on Microsoft Windows [Version 10.0.22631.4169], locale pt-BR)
    • Flutter version 3.24.3 on channel stable at C:\Users\felip_0vh5fa6\.puro\envs\stable\flutter
    ! Warning: `dart` on your path resolves to
      C:\Users\felip_0vh5fa6\.puro\shared\caches\fdf38910bad4a775c86b6c9a77b4856c3c26c8cd\dart-sdk\bin\dart.exe, which is
      not inside your current Flutter SDK checkout at C:\Users\felip_0vh5fa6\.puro\envs\stable\flutter. Consider adding
      C:\Users\felip_0vh5fa6\.puro\envs\stable\flutter\bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 2663184aa7 (9 days ago), 2024-09-11 16:27:48 -0500
    • Engine revision 36335019a8
    • Dart version 3.5.3
    • DevTools version 2.37.3
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to
      perform update checks and upgrades.

### Everything else is fine, focus on the above

! Doctor found issues in 1 category.

Expected results

Since that Flutter environment I called stable is actually symlinking to that dart.exe it should not show that warning.

Activity

  1. iapicca commented on Sep 21, 2024

    @iapicca
  2. pingbird commented on Sep 22, 2024

    @pingbird
    Member

    The current check does consider symlinks of the flutter sdk itself, but not of the directory that the binary sits in (in your case, the cache dir is a symlink to .puro\shared\caches\fdf38910bad4a775c86b6c9a77b4856c3c26c8cd)

    ValidationMessage? _validateSdkBinary(String binary, String flutterRoot) {

  3. darshankawar commented on Sep 23, 2024

    @darshankawar
    Member

    @FMorschel
    A similar issue was filed by @iapicca which was closed in favor of #115651 that you can check if it resonates / resembles your case or not.

  4. added
    waiting for responseThe Flutter team cannot make further progress on this issue until the original reporter responds
    on Sep 23, 2024
  5. FMorschel commented on Sep 23, 2024

    @FMorschel
    ContributorAuthor

    Yes that would be it. Thanks, missed it!

  6. removed
    waiting for responseThe Flutter team cannot make further progress on this issue until the original reporter responds
    on Sep 23, 2024
  7. added
    r: duplicateIssue is closed as a duplicate of an existing issue
    and removed
    in triagePresently being triaged by the triage team
    on Sep 24, 2024
  8. github-actions commented on Oct 8, 2024

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  9. locked as resolved and limited conversation to collaborators on Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    r: duplicateIssue is closed as a duplicate of an existing issue

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions