You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Proposal: Remove engine top-level orchestrator builders that only kick off and collect sub-builds (no generators), and hoist sub-build to "standalone" #155041
Some "top-level" orchestrator builds only kick off sub-builds and then do nothing but wait for the results. Mac mac_unopt is an example of this:
Note there are no "Global generators" or tests.
GitHub currently only allows reruns on these top-level builds when there's a failure in the subbuild. In the case of mac_unopt that means all the sub-builds are re-run, even though most of them succeeded (example). Rerunning all of them ties up CI resources and makes the rerun longer, if the failing test isn't the long-pole of the top-level build total time. It also means the top-level orchestrator build idles bot while it waits on the builds to finish.
This is how the builds with json files under ci/builders/standalone work.
@zanderso do you see a downside to moving the build-only (no tests, generators) builds to standalone (plus recipe change)? Was that always the plan with standalone? Is this proposal already half-implemented?
How many builders can we elevate? Are most of the builders able to do this and it's just the mac_ios_engine that's special?
Are the "waiting" machines actually consuming machines that could be used for other builds and tests?
@jtmcdole yes, the waiting "orchestrator" builds are consuming a machine. We've tried to make as many of them as possible "cheap" Linux VMs which we have many of, but the mac_unopt example is holding a more precious Mac.
changed the title [-]Proposal: Remove engine top-level builder that only kick off and collect sub-builds (no generators), and hoist sub-build to top[/-][+]Proposal: Remove engine top-level orchestrator builders that only kick off and collect sub-builds (no generators), and hoist sub-build to top[/+]on Sep 12, 2024
changed the title [-]Proposal: Remove engine top-level orchestrator builders that only kick off and collect sub-builds (no generators), and hoist sub-build to top[/-][+]Proposal: Remove engine top-level orchestrator builders that only kick off and collect sub-builds (no generators), and hoist sub-build to "standalone"[/+]on Sep 12, 2024
This is how the builds with json files under ci/builders/standalone work.
@zanderso do you see a downside to moving the build-only (no tests, generators) builds to standalone (plus recipe change)? Was that always the plan with standalone? Is this proposal already half-implemented?
Yes, this is already half-implemented. I don't think any recipe change is needed for this, but I might be missing something. The only possible downside I could imagine is if someone wants to expand a file like windows_unopt.json with some additional builds, it will have to jump back out of standalone, and that would be some additional churn. But afaict that's how the engine_v2 recipes are designed to work, so it's not really the end of the world.
@reidbaker if linux_android_emulator_34 and linux_android_emulator were moved to standalone then I think you could deduplicate them into one json file per build (android_emulator_debug_x64 and android_emulator_debug_x86), and set the android_virtual_device and avd_cipd_version dependencies from the .ci.yaml.
The android_emulator_debug_x86 one would only need to swap avd_cipd_version per build and not android_virtual_device since both are targeting SDK 28 Android Unit Tests (API 28) (if I'm reading flutter-team-archive/engine#54186 right).
You would then only need to create a new builder in the .ci.yaml for the next SDK, and not copy the entire json config.
This issue is marked P1 but has had no recent status updates.
The P1 label indicates high-priority issues that are at the top of the work list. This is the highest priority level a bug can have if it isn't affecting a top-tier customer or breaking the build. Bugs marked P1 are generally actively being worked on unless the assignee is dealing with a P0 bug (or another P1 bug). Issues at this level should be resolved in a matter of months and should have monthly updates on GitHub.
Please consider where this bug really falls in our current priorities, and label it or assign it accordingly. This allows people to have a clearer picture of what work is actually planned. Thanks!
This issue is marked P1 but has had no recent status updates.
The P1 label indicates high-priority issues that are at the top of the work list. This is the highest priority level a bug can have if it isn't affecting a top-tier customer or breaking the build. Bugs marked P1 are generally actively being worked on unless the assignee is dealing with a P0 bug (or another P1 bug). Issues at this level should be resolved in a matter of months and should have monthly updates on GitHub.
Please consider where this bug really falls in our current priorities, and label it or assign it accordingly. This allows people to have a clearer picture of what work is actually planned. Thanks!
Activity
jtmcdole commentedon Sep 12, 2024
A couple of questions for my own edification:
mac_ios_enginethat's special?I like the idea on the surface.
zanderso commentedon Sep 12, 2024
This is how the builds with json files under
ci/builders/standalonework. One example iswindows_unopt:https://github.com/flutter/engine/blob/main/ci/builders/standalone/windows_unopt.json
https://github.com/flutter/engine/blob/main/.ci.yaml#L555 <- note that the recipe is
engine_v2/builderrather thanengine_v2/engine_v2.https://ci.chromium.org/ui/p/flutter/builders/prod/Windows%20windows_unopt/8783/overview <- example build.
The
engine_v2recipe runs all the sub-builds and then runs the global tests and generators on the orchestrator.The
builderrecipe just runs the single build definition in the indicated json file.jmagman commentedon Sep 12, 2024
@zanderso do you see a downside to moving the build-only (no tests, generators) builds to
standalone(plus recipe change)? Was that always the plan with standalone? Is this proposal already half-implemented?@jtmcdole I started making a list at the bottom of the issue starting with "Linux clangd" but I ran out of steam about halfway through, all the json files in https://github.com/flutter/engine/tree/38e37ce9879b2efe4890a8d09f4207dc5686a1bd/ci/builders should be audited as part of this change.
@jtmcdole yes, the waiting "orchestrator" builds are consuming a machine. We've tried to make as many of them as possible "cheap" Linux VMs which we have many of, but the
mac_unoptexample is holding a more precious Mac.[-]Proposal: Remove engine top-level builder that only kick off and collect sub-builds (no generators), and hoist sub-build to top[/-][+]Proposal: Remove engine top-level orchestrator builders that only kick off and collect sub-builds (no generators), and hoist sub-build to top[/+][-]Proposal: Remove engine top-level orchestrator builders that only kick off and collect sub-builds (no generators), and hoist sub-build to top[/-][+]Proposal: Remove engine top-level orchestrator builders that only kick off and collect sub-builds (no generators), and hoist sub-build to "standalone"[/+]jtmcdole commentedon Sep 12, 2024
Lets chat about this in a merged repo world
zanderso commentedon Sep 13, 2024
Yes, this is already half-implemented. I don't think any recipe change is needed for this, but I might be missing something. The only possible downside I could imagine is if someone wants to expand a file like
windows_unopt.jsonwith some additional builds, it will have to jump back out ofstandalone, and that would be some additional churn. But afaict that's how the engine_v2 recipes are designed to work, so it's not really the end of the world.Remove Linux orchestrator builds that only kick off one other build a…
jmagman commentedon Oct 22, 2024
@reidbaker if linux_android_emulator_34 and linux_android_emulator were moved to
standalonethen I think you could deduplicate them into one json file per build (android_emulator_debug_x64 and android_emulator_debug_x86), and set theandroid_virtual_deviceandavd_cipd_versiondependencies from the .ci.yaml.The
android_emulator_debug_x86one would only need to swap avd_cipd_version per build and not android_virtual_device since both are targeting SDK 28Android Unit Tests (API 28)(if I'm reading flutter-team-archive/engine#54186 right).You would then only need to create a new builder in the .ci.yaml for the next SDK, and not copy the entire json config.
Add standalone 'Mac clangd' builder to replace 'Linux mac_clangd' orc…
Add standalone 'Mac clangd' builder to replace 'Linux mac_clangd' orc…
flutter-triage-bot commentedon Jun 4, 2025
This issue is marked P1 but has had no recent status updates.
The P1 label indicates high-priority issues that are at the top of the work list. This is the highest priority level a bug can have if it isn't affecting a top-tier customer or breaking the build. Bugs marked P1 are generally actively being worked on unless the assignee is dealing with a P0 bug (or another P1 bug). Issues at this level should be resolved in a matter of months and should have monthly updates on GitHub.
Please consider where this bug really falls in our current priorities, and label it or assign it accordingly. This allows people to have a clearer picture of what work is actually planned. Thanks!
flutter-triage-bot commentedon Oct 12, 2025
This issue is marked P1 but has had no recent status updates.
The P1 label indicates high-priority issues that are at the top of the work list. This is the highest priority level a bug can have if it isn't affecting a top-tier customer or breaking the build. Bugs marked P1 are generally actively being worked on unless the assignee is dealing with a P0 bug (or another P1 bug). Issues at this level should be resolved in a matter of months and should have monthly updates on GitHub.
Please consider where this bug really falls in our current priorities, and label it or assign it accordingly. This allows people to have a clearer picture of what work is actually planned. Thanks!
Remove Linux orchestrator builds that only kick off one other build a…
Run the mac_unopt sub-builds as standalone builders (flutter#195868)
Remove Mac mac_unopt builder (flutter#196027)