-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Open
Labels
P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter projectc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.c: disabled testTracks the restoration of a disabled testTracks the restoration of a disabled testp: webviewThe WebView pluginThe WebView pluginpackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.platform-iosiOS applications specificallyiOS applications specificallyteam-iosOwned by iOS platform teamOwned by iOS platform teamtriaged-iosTriaged by iOS platform teamTriaged by iOS platform team
Description
The legacy tests for inline video are failing to complete:
43:16 +45 ~1: ... Video playback policy Video plays inline when allowsInlineMediaPlayback is true
43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: Video playback policy Video plays inline when allowsInlineMediaPlayback is true - did not complete [E]
43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: Video playback policy Video plays full screen when allowsInlineMediaPlayback is false - did not complete [E]
43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: Video playback policy (tearDownAll) - did not complete [E]
43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: Audio playback policy (setUpAll) - did not complete [E]
43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: Audio playback policy Auto media playback - did not complete [E]
43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: Audio playback policy Changes to initialMediaPlaybackPolicy are ignored - did not complete [E]
43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: Audio playback policy (tearDownAll) - did not complete [E]
43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: getTitle - did not complete [E]
43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: Programmatic Scroll setAndGetScrollPosition - did not complete [E]
43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: NavigationDelegate can allow requests - did not complete [E]
43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: NavigationDelegate onWebResourceError - did not complete [E]
43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: NavigationDelegate onWebResourceError is not called with valid url - did not complete [E]
43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: NavigationDelegate onWebResourceError only called for main frame - did not complete [E]
43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: NavigationDelegate can block requests - did not complete [E]
43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: NavigationDelegate supports asynchronous decisions - did not complete [E]
43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: launches with gestureNavigationEnabled on iOS - did not complete [E]
43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: target _blank opens in same window - did not complete [E]
43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: can open new window and go back - did not complete [E]
43:16 +45 ~1: /Volumes/Work/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart: (tearDownAll) - did not complete [E]
43:16 +45 ~1: Some tests failed.
[packages/webview_flutter/webview_flutter_wkwebview completed in 43m 22s]
It seems only the legacy tests fail while the same test with the public API still passes.
I was able to reproduce it locally as well.
Metadata
Metadata
Assignees
Labels
P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter projectc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.c: disabled testTracks the restoration of a disabled testTracks the restoration of a disabled testp: webviewThe WebView pluginThe WebView pluginpackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.platform-iosiOS applications specificallyiOS applications specificallyteam-iosOwned by iOS platform teamOwned by iOS platform teamtriaged-iosTriaged by iOS platform teamTriaged by iOS platform team